Skip to content

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Jul 30, 2025

Updates to the latest version of Transformers.

Notable changes:

  • Transformers backend:
    • Get the tp_plan from the config of the base model because it is no longer added to the base model itself post init
    • Add a default mapping from nn.Linear to ReplicatedLinear to enable weight loaders like BitsAndBytesModelLoader to work with models that do not support TP if TP is disabled
    • Decoder modules no longer return tuple as of Refactor the way we handle outputs for new llamas and new models huggingface/transformers#39120 so return_tuple has been removed from PPMissingLayer.forward()

Enables the proper type hinting introduced by #21913

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 30, 2025
@mergify mergify bot added the ci/build label Jul 30, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the transformers library to version v4.54.1 and huggingface-hub to v0.34.3. While this is a necessary update, it introduces potential risks due to reliance on workarounds and private APIs from older transformers versions. I recommend addressing the following points to ensure stability and correctness. First, a critical issue in vllm/model_executor/models/transformers.py is the use of the private _attn_implementation API. With transformers v4.54.1, the public model.set_attn_implementation() should be used to avoid silently disabling vLLM's custom attention, which would impact performance and correctness. Second, there are high-risk, potentially obsolete workarounds in vllm/config.py for gemma2 and gemma3n_text model configs, and in vllm/transformers_utils/tokenizer.py for ChatGLMTokenizer. These may now be fixed in transformers and could cause incorrect behavior if they override updated library logic. Verifying and removing these if they are no longer necessary is highly recommended.

@DarkLight1337
Copy link
Member

DarkLight1337 commented Jul 30, 2025

What failures are introduced by that PR? From my understanding those test failures also happen on main.

Signed-off-by: Harry Mellor <[email protected]>
@hmellor
Copy link
Member Author

hmellor commented Jul 30, 2025

I wasn't aware they were also on main. I assumed they were from that PR because many of them refer to the same configs that were modified.

@DarkLight1337
Copy link
Member

Well in any case, it's great to fix them anyway

@DarkLight1337
Copy link
Member

Ok I figured out that some of the failures in that PR are caused by missing trust_remote_code=True (because we previously loaded those configs from vLLM directly), let me open a separate PR.

Signed-off-by: Harry Mellor <[email protected]>
@hmellor
Copy link
Member Author

hmellor commented Jul 30, 2025

Ok, happy to review once it's open

@DarkLight1337
Copy link
Member

Opened #21934

hmellor added 4 commits July 30, 2025 15:59
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
@DarkLight1337
Copy link
Member

Hope this passes now

@noooop
Copy link
Contributor

noooop commented Jul 31, 2025

gte-Qwen2-1.5B-instruct hf Implementation does not support v4.54.1

@hmellor
Copy link
Member Author

hmellor commented Jul 31, 2025

@noooop are you suggesting that we upper bound this model in tests to 4.53.2?

@hmellor
Copy link
Member Author

hmellor commented Aug 5, 2025

Ok, I'll make that change in the next batch of commits (I'll let the tests run to completion)

@zyongye zyongye mentioned this pull request Aug 6, 2025
3 tasks
@zyongye
Copy link
Member

zyongye commented Aug 6, 2025

How long can we land this? Need this first before merging gpt-oss changes (#22259)

@DarkLight1337
Copy link
Member

We just need to get CI to pass

@WoosukKwon WoosukKwon merged commit 796bae0 into vllm-project:main Aug 6, 2025
12 of 16 checks passed
@hmellor hmellor deleted the update-transformers-4-54 branch August 6, 2025 07:55
@hmellor
Copy link
Member Author

hmellor commented Aug 6, 2025

I understand this was a priority for gpt-oss, I'll work on hotfixiing anything that wasn't fully resolved in CI

@myselvess myselvess mentioned this pull request Aug 6, 2025
4 tasks
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
myselvess pushed a commit to myselvess/vllm that referenced this pull request Aug 7, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
jingyu-ml pushed a commit to jingyu-ml/vllm that referenced this pull request Aug 8, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: jingyu <[email protected]>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: Noam Gat <[email protected]>
yyihuang pushed a commit to yyihuang/vllm that referenced this pull request Aug 11, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: Avery Yingyi Huang <[email protected]>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Aug 14, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: Boyuan Feng <[email protected]>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: Diego-Castan <[email protected]>
juuice-lee pushed a commit to juuice-lee/vllm-moe.code that referenced this pull request Aug 18, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: Xiao Yu <[email protected]>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Signed-off-by: Xiao Yu <[email protected]>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Co-authored-by: DarkLight1337 <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Isotr0py <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build multi-modality Related to multi-modality (#4194) qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants