-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
[Speculators][Speculative Decoding] Add Eagle3 Support For HunYuan Model #22080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Eagle3 speculative decoding to the HunYuan model. The changes are extensive, touching model definitions, configuration, and tests. The core logic for Eagle3 support seems to be implemented in a new file hunyuan_v1_eagle3.py
and by modifying hunyuan_v1.py
to support auxiliary hidden states.
My review has identified a few critical and high-severity issues:
- A potential
TypeError
inhunyuan_v1.py
due to an unhandledNone
value, which could cause a crash. - Inappropriate use of inheritance in the new
hunyuan_v1_eagle3.py
model, which will make the code harder to maintain. - A missing type hint in
hunyuan_v1.py
that was removed instead of being updated. - Incomplete test data in
tests/models/registry.py
which will likely break some tests.
I've provided detailed comments and suggestions for these issues. Addressing them will improve the correctness and maintainability of the code.
This pull request has merge conflicts that must be resolved before it can be |
Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Asher <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Asher <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Asher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the code LGTM now
Head branch was pushed to by a user without write access
Fix Hunyuan eagle structure. accept rate incease, from 16% -> 40% in test case prompt change review comments. fix test case. eagle3: hunyuan fix fc test: by pass tree attention. test: refine spec decode code. test: remove gpu_memory_utilization Signed-off-by: Asher Zhang <[email protected]>
Signed-off-by: Asher Zhang <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Asher <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Asher <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Asher <[email protected]>
Signed-off-by: Asher Zhang <[email protected]>
Signed-off-by: Asher Zhang <[email protected]>
Signed-off-by: Asher Zhang <[email protected]>
Head branch was pushed to by a user without write access
Signed-off-by: Asher <[email protected]>
This pull request has merge conflicts that must be resolved before it can be |
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Add Eagle3 support for Hunyuan V1 models.
Test Plan
Test Result
End 2 End Unit test
======================= 1 passed, 5 deselected in 51.72s =======================
Service
(Optional) Documentation Update