Post-review fixes: username bug, CI, platform marker, README polish#1
Merged
Post-review fixes: username bug, CI, platform marker, README polish#1
Conversation
…polish - Fix username default bug: main.py no longer short-circuits the YAML default_username - Add GitHub Actions CI running ruff + pytest on Python 3.12/3.13 - Mark pyobjc-framework-corewlan as macOS-only in pyproject.toml - Add test and comment documenting recommend_channel tiebreaker policy - Add screenshot placeholder and Security Notes section to README
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses feedback from the initial code review on
main.Bug fix
main.pypassedusername or "admin"to the device loader, which short-circuited the YAMLdefault_usernamesetting. Now passesusernamethrough asNonewhen unset, letting the loader apply the YAML default correctly.CI
.github/workflows/ci.yml— runsruff checkandpytest -von push and PR, matrix over Python 3.12 and 3.13, macOS runner (CoreWLAN is Mac-only).Packaging
pyobjc-framework-corewlanassys_platform == 'darwin'so the package installs cleanly on Linux/Windows for contributors who can't run the live scanner. The scanner already returns[]when CoreWLAN isn't importable.Tests & docs
test_tiebreaker_prefers_current_channeland a comment inrecommend_channeldocumenting that the tiebreaker intentionally keeps clients on their current channel when congestion is equal.docs/screenshot.png— to be captured separately).Test plan
uv run pytest -v— 28/28 passing locallyuvx ruff check .— clean