fix: replace SELECT * with explicit fields in clone_script function #6914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace SELECT * query with explicit column selection in the clone_script function to improve code clarity and ensure all Script struct fields are properly mapped from the database query. This change lists all 37 fields from the Script struct explicitly, making the query more maintainable and less prone to errors when the struct or schema changes. Fixes #6913 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace SELECT * query with explicit column selection in the clone_script
function to improve code clarity and ensure all Script struct fields are
properly mapped from the database query.
This change lists all 37 fields from the Script struct explicitly, making
the query more maintainable and less prone to errors when the struct or
schema changes.
Fixes #6913
Generated with Claude Code