Skip to content

fix: replace SELECT * with explicit fields in clone_script function #6914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: replace SELECT * with explicit fields in clone_script function #6914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions backend/windmill-common/src/scripts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,12 +730,20 @@ pub async fn clone_script<'c>(
deployment_message: Option<String>,
tx: &mut sqlx::Transaction<'c, sqlx::Postgres>,
) -> crate::error::Result<i64> {
let s =
sqlx::query_as::<_, Script>("SELECT * FROM script WHERE hash = $1 AND workspace_id = $2")
.bind(base_hash.0)
.bind(w_id)
.fetch_one(&mut **tx)
.await?;
let s = sqlx::query_as::<_, Script>(
"SELECT workspace_id, hash, path, parent_hashes, summary, description, content, \
created_by, created_at, archived, schema, deleted, is_template, extra_perms, \
lock, lock_error_logs, language, kind, tag, draft_only, envs, concurrent_limit, \
concurrency_time_window_s, cache_ttl, dedicated_worker, ws_error_handler_muted, \
priority, timeout, delete_after_use, restart_unless_cancelled, concurrency_key, \
visible_to_runner_only, no_main_func, codebase, has_preprocessor, on_behalf_of_email, \
assets \
FROM script WHERE hash = $1 AND workspace_id = $2",
)
.bind(base_hash.0)
.bind(w_id)
.fetch_one(&mut **tx)
.await?;

let ns = NewScript {
path: s.path.clone(),
Expand Down