chore: common locator placement - WPB-20289 #3653
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findms
changed the title
findms
changed the title
findms
changed the title
findms
changed the title
6 tasks
netbe
reviewed
Oct 1, 2025
| "account.hint" = "Doppeltippen, um Konto zu öffnen"; | ||
| import Foundation | ||
|
|
||
| public enum Locators { |
There was a problem hiding this comment.
suggestion: I would move the locators to WireUI and have a specific target : Locators for it that way CI does not trigger running all tests when something changed in Foundation
otherwise we might want to ignore this file in the CI
Test Results2 085 tests 2 057 ✅ 3m 3s ⏱️ Results for commit bc9cb02. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Please describe the issue.
Optional: add details about technical approach, solutions etc.
Optional: reference dependencies to other pull requests etc.
Testing
Describe how to test.
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: