Skip to content

Conversation

johnxnguyen
Copy link
Collaborator

@johnxnguyen johnxnguyen commented Oct 8, 2025

StoryWPB-20714 [iOS] Upload asset with additional metadata

Issue

In this PR we include additional metadata when uploading assets if the asset audit log feature is enabled.

Changes include:

  • adjust api for appending image messages to accept a SendableImage rather than Data. This allow us to include additional metadata about the image such as the name and utType (which we'll upload)
  • unpack the necessary metadata and include it in the multipart data when uploading assets
  • only upload this data under certain conditions (feature is enabled, not connected to cloud backend)
  • delete dead code

Testing

  1. Connect to backend that has asset audit log enabled
  2. Send various asset messages (image, audio, video, file)
  3. Observe the network via a proxy (e.g Proxyman) and check the upload contains the metadata in the raw body.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@johnxnguyen johnxnguyen marked this pull request as ready for review October 9, 2025 12:35
@johnxnguyen johnxnguyen marked this pull request as draft October 9, 2025 12:43
@johnxnguyen johnxnguyen marked this pull request as ready for review October 9, 2025 12:43
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Test Results

   11 files  1 046 suites   14m 45s ⏱️
7 770 tests 7 742 ✅ 28 💤 0 ❌
7 772 runs  7 744 ✅ 28 💤 0 ❌

Results for commit 04e4835.

♻️ This comment has been updated with latest results.

@johnxnguyen johnxnguyen requested review from jullianm and netbe October 9, 2025 14:34
@johnxnguyen johnxnguyen marked this pull request as draft October 9, 2025 14:45
@johnxnguyen johnxnguyen marked this pull request as ready for review October 9, 2025 14:45
Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments before approving

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@johnxnguyen johnxnguyen enabled auto-merge (squash) October 13, 2025 09:10
@johnxnguyen johnxnguyen merged commit 12524bc into release/cycle-4.8 Oct 14, 2025
19 checks passed
@johnxnguyen johnxnguyen deleted the feat/asset-audit-log-metadata-wpb-20714 branch October 14, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants