-
Notifications
You must be signed in to change notification settings - Fork 24
feat: asset audit log metadata - WPB-20714 #3703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: asset audit log metadata - WPB-20714 #3703
Conversation
…wireapp/wire-ios into feat/asset-audit-log-metadata-wpb-20714
Test Results 11 files 1 046 suites 14m 45s ⏱️ Results for commit 04e4835. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments before approving
wire-ios-data-model/Source/Model/Conversation/ZMConversation+Message.swift
Show resolved
Hide resolved
wire-ios-data-model/Source/Model/Conversation/ZMConversation+Message.swift
Outdated
Show resolved
Hide resolved
wire-ios-data-model/Source/Model/Conversation/ZMConversation+Message.swift
Outdated
Show resolved
Hide resolved
wire-ios-data-model/Source/Model/Conversation/ZMConversation+Message.swift
Outdated
Show resolved
Hide resolved
...rsation/InputBar/ConversationInputBarViewController/ConversationInputBarViewController.swift
Show resolved
Hide resolved
...ire-iOS/Sources/UserInterface/Conversation/InputBar/ConversationInputBarSendController.swift
Show resolved
Hide resolved
.../Sources/UserInterface/Conversation/InputBar/ConversationInputBarViewController+Camera.swift
Show resolved
Hide resolved
.../Sources/UserInterface/Conversation/InputBar/ConversationInputBarViewController+Camera.swift
Show resolved
Hide resolved
...ces/UserInterface/Conversation/InputBar/ConversationInputBarViewController+DragAndDrop.swift
Show resolved
Hide resolved
…wireapp/wire-ios into feat/asset-audit-log-metadata-wpb-20714
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Issue
In this PR we include additional metadata when uploading assets if the asset audit log feature is enabled.
Changes include:
SendableImage
rather thanData
. This allow us to include additional metadata about the image such as the name and utType (which we'll upload)Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: