Add check for string size in ConvertToC function#8446
Open
Gnorkus wants to merge 1 commit intowpilibsuite:mainfrom
Open
Add check for string size in ConvertToC function#8446Gnorkus wants to merge 1 commit intowpilibsuite:mainfrom
Gnorkus wants to merge 1 commit intowpilibsuite:mainfrom
Conversation
Check for non-zero string size before copying.
calcmogul
reviewed
Dec 4, 2025
| std::memcpy(write, str.data(), str.size()); | ||
| size_t n = str.size(); | ||
| char* write = WPI_AllocateString(output, n); | ||
| if (n>0) |
Member
There was a problem hiding this comment.
Our style guide requires curly braces on control flow statements.
Contributor
|
What's the purpose of these check? It seems like this check is unnecessary: See https://stackoverflow.com/questions/3751797/can-i-call-memcpy-and-memmove-with-number-of-bytes-set-to-zero and others. |
Member
That post is only if both pointers are valid. Memcpy and memmove are UB if any of the pointers are null. Which an empty string view is. |
Contributor
|
Ah, I missed that empty string views have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for non-zero string size before copying.