Skip to content

fix: Use manifestVersion from CLI during manifest generation#2306

Merged
aklinker1 merged 2 commits intomainfrom
use-wxt-manifest-version
Apr 27, 2026
Merged

fix: Use manifestVersion from CLI during manifest generation#2306
aklinker1 merged 2 commits intomainfrom
use-wxt-manifest-version

Conversation

@aklinker1
Copy link
Copy Markdown
Member

@aklinker1 aklinker1 commented Apr 27, 2026

Overview

During manifest generation, wxt.config.maniifestVersion is the source of truth - if an extension uses wxt --mv3, but has manifest: { manifest_version: 2 } in their config file, we should always use the manifest version from the wxt.config object, not the manifest object we're in the middle of generating.

In theory, they should always be the same, but I could see some funky edge case where someone is modifying the manifest.version through hooks.

Manual Testing

Run tests:

bun run --cwd packages/wxt test

Related Issue

Noticed we were using different sources for the manifest version while reviewing #2010 today.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 27, 2026

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit b1a17c3
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/69eec1992f6c940008b92459
😎 Deploy Preview https://deploy-preview-2306--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aklinker1 aklinker1 changed the title fix: Use manifestVersion from CLI during manifest generation fix: Use manifestVersion from CLI during manifest generation Apr 27, 2026
@github-actions github-actions Bot added the pkg/wxt Includes changes to the `packages/wxt` directory label Apr 27, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 27, 2026

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2306

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2306

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2306

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2306

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2306

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2306

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2306

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2306

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2306

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2306

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2306

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2306

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2306

wxt

npm i https://pkg.pr.new/wxt@2306

commit: b1a17c3

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.86%. Comparing base (a2212f7) to head (b1a17c3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2306      +/-   ##
==========================================
+ Coverage   79.70%   79.86%   +0.15%     
==========================================
  Files         130      130              
  Lines        3804     3804              
  Branches      861      861              
==========================================
+ Hits         3032     3038       +6     
+ Misses        688      683       -5     
+ Partials       84       83       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aklinker1 aklinker1 merged commit 8b530bc into main Apr 27, 2026
26 checks passed
@aklinker1 aklinker1 deleted the use-wxt-manifest-version branch April 27, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg/wxt Includes changes to the `packages/wxt` directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant