fix: Use manifestVersion from CLI during manifest generation#2306
Merged
fix: Use manifestVersion from CLI during manifest generation#2306
manifestVersion from CLI during manifest generation#2306Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
manifestVersion from CLI during manifest generation
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/is-background
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2306 +/- ##
==========================================
+ Coverage 79.70% 79.86% +0.15%
==========================================
Files 130 130
Lines 3804 3804
Branches 861 861
==========================================
+ Hits 3032 3038 +6
+ Misses 688 683 -5
+ Partials 84 83 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
During manifest generation,
wxt.config.maniifestVersionis the source of truth - if an extension useswxt --mv3, but hasmanifest: { manifest_version: 2 }in their config file, we should always use the manifest version from thewxt.configobject, not themanifestobject we're in the middle of generating.In theory, they should always be the same, but I could see some funky edge case where someone is modifying the
manifest.versionthrough hooks.Manual Testing
Run tests:
bun run --cwd packages/wxt testRelated Issue
Noticed we were using different sources for the manifest version while reviewing #2010 today.