Skip to content

fix: Use manifestVersion from CLI during manifest generation #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aklinker1 merged 2 commits into from
Apr 27, 2026
+3 −3
Merged

fix: Use manifestVersion from CLI during manifest generation #2306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e109263
fix: Use manifestVersion from CLI during manifest generation
aklinker1 Apr 27, 2026
b1a17c3
Merge branch 'main' into use-wxt-manifest-version
aklinker1 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/wxt/src/core/utils/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ function addEntrypoints(
options.theme_icons = popup.options.themeIcons;

const actionKey =
manifest.manifest_version === 2
wxt.config.manifestVersion === 2
? (popup.options.actionType ?? 'browser_action')
: wxt.config.browser === 'firefox' &&
popup.options.actionType === 'page_action'
Expand Down Expand Up @@ -493,7 +493,7 @@ function addDevModeCsp(manifest: Browser.runtime.Manifest): void {
const permission = `${permissionUrl}*`;
const allowedCsp = wxt.server?.origin ?? 'http://localhost:*';

if (manifest.manifest_version === 3) {
if (wxt.config.manifestVersion === 3) {
addHostPermission(manifest, permission);
} else {
addPermission(manifest, permission);
Expand All @@ -502,7 +502,7 @@ function addDevModeCsp(manifest: Browser.runtime.Manifest): void {
const extensionPagesCsp = new ContentSecurityPolicy(
// @ts-expect-error: extension_pages exists, we convert MV2 CSPs to this earlier in the process
manifest.content_security_policy?.extension_pages ??
(manifest.manifest_version === 3
(wxt.config.manifestVersion === 3
? DEFAULT_MV3_EXTENSION_PAGES_CSP
: DEFAULT_MV2_CSP),
);
Expand Down
Loading