simple_http: improve dependency config for boost

[gibbz00]

Two commits: The first makes the switch to using CMake as the boost build system. The second adds the missing asio feature.

[gemini-code-assist]

Summary of Changes

Hello @gibbz00, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the dependency management for the simple_http package by updating its xmake.lua configuration. The primary goal is to ensure that the Boost library is correctly configured with the asio feature enabled, which is crucial for network operations, and to align with a CMake-based build approach for Boost.

Highlights

• Boost Dependency Configuration: The Boost dependency configuration was updated to explicitly enable the asio feature, aligning with the stated intent of using CMake as the build system for Boost.
• Dependency Ordering: The order of openssl and nghttp2 dependencies was adjusted in the xmake.lua file, though this change does not alter functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• packages/s/simple_http/xmake.lua
  • Modified the add_deps call for Boost to include {configs = {asio = true}}.
  • Reordered the add_deps calls for openssl and nghttp2.

Activity

• No activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the boost dependency for simple_http, switching to the CMake build system and enabling the asio feature. However, a critical high-severity security issue was identified: the change introduces a dependency on an unsupported OpenSSL version (1.1.1), which is End of Life and no longer receives security updates. It is essential to update this to a supported version like OpenSSL 3.x to mitigate unpatched vulnerabilities. On the positive side, the PR improves clarity by splitting nghttp2 and openssl dependencies into separate add_deps calls. A suggestion for alphabetical sorting of dependencies has also been made to enhance maintainability.

[gemini-code-assist]

The openssl dependency is introduced without a version specification, which will resolve to an unsupported OpenSSL 1.1.1 series. This version has reached End of Life and no longer receives security updates, posing a significant security risk. It is critical to constrain this dependency to a supported major version, such as 3.x. Additionally, for consistency and improved maintainability, consider listing dependencies in alphabetical order.

    add_deps("openssl", {versions = ">=3.0.0"})

[gibbz00]

I believe CI is failing due to fantasy-peak/simple_http#3. It shouldn't have anything to do with the changes made here.