Skip to content

simple_http: improve dependency config for boost #9326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gibbz00 wants to merge 2 commits into
base: dev
Choose a base branch
from
+3 −2
Open

simple_http: improve dependency config for boost #9326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e809fe
simple_http: build with cmake
gibbz00 Feb 12, 2026
00f76cc
simple_http: include asio in boost config
gibbz00 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/s/simple_http/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ package("simple_http")
add_versions("v0.2.0", "1c2ab7c2be317f95e34bdbe6c753293495b6743828ec4115b5f3c383c8c95adc")

add_deps("cmake")
add_deps("boost", {configs = {cmake = false}})
add_deps("nghttp2", "openssl")
add_deps("boost", {configs = {asio = true}})
add_deps("openssl")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

The openssl dependency is introduced without a version specification, which will resolve to an unsupported OpenSSL 1.1.1 series. This version has reached End of Life and no longer receives security updates, posing a significant security risk. It is critical to constrain this dependency to a supported major version, such as 3.x. Additionally, for consistency and improved maintainability, consider listing dependencies in alphabetical order.

    add_deps("openssl", {versions = ">=3.0.0"})

add_deps("nghttp2")

on_install("linux", "cross", "bsd", function (package)
import("package.tools.cmake").install(package)
Expand Down
Loading