Repository navigation
Drop all-zero stroke-dasharray when emitting PDF - #382
Open
amandeavor wants to merge 1 commit into
Open
amandeavor wants to merge 1 commit into
amandeavor wants to merge 1 commit into
Conversation
PDF dash patterns with only zero lengths are invalid and cause viewer errors. When SVG specifies values like "0.00 0.00", treat the stroke as solid instead of writing the pattern. Fixes yWorks#343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stroke-dasharray="0.00 0.00"is valid SVG but produces an invalid PDF dash pattern. PDF viewers (including Acrobat) can error on dash arrays whose lengths are all zero.Fixes #343
Solution
When a parsed
stroke-dasharraycontains only zeros, emit a solid stroke ([]) instead of writing the zero-length dash pattern.Verification
test/strokes/zero-dasharrayregression covering0.00 0.00alongside a solid linedoperatornpm test -- test/strokes/strokes.spec.ts— 4 passednpm run typecheck/npm run lint/npm run format— clean