Skip to content

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Mar 22, 2022

Fixes #289

use yarnInstall if --yarn option is used:

@glensc
Copy link
Contributor Author

glensc commented Mar 22, 2022

I don't know how to test this without code being published in npm registry.

@glensc glensc mentioned this pull request Mar 22, 2022
@oklas
Copy link

oklas commented Mar 24, 2022

It is possible to install package for testing. Package may be installed from local folder or from tarball, both yarn and npm.

@glensc glensc marked this pull request as draft March 24, 2022 11:11
@glensc
Copy link
Contributor Author

glensc commented Mar 24, 2022

Probably more changes needed, as this did not have any effect at all

@oklas
Copy link

oklas commented Mar 24, 2022

Perhaps yes

@oklas
Copy link

oklas commented Mar 25, 2022

Moreover, I do not see similar testing for npm either. But I noticed that the readme template generator should also be changed here

@glensc
Copy link
Contributor Author

glensc commented Mar 26, 2022

PR for readme sub-generator:

let's get that resolved and merged first.

@glensc glensc marked this pull request as ready for review March 24, 2025 02:04
@glensc
Copy link
Contributor Author

glensc commented Mar 24, 2025

Rebased after #294 merge

I don't use this anymore, so either merge or close.

@JoshuaKGoldberg
Copy link

👋 Thanks for the merge->rebase! Coming over from yeoman/yeoman#1779, we're still ramping up on PR infrastructure and reviews. Lots of things are broken and need to be overhauled. But we're hopeful we'll get to this Soon ™️!

@mshima
Copy link
Member

mshima commented Mar 24, 2025

npmInstall/yarnInstall apis has been removed.
Install task is executed automatically by the environment if package.json change was detected (if the file was committed).

  • Client manager can be passed by --node-package-manager option otherwise it is detected by lock file existence and falls back to npm.
  • A generator can force a pm using constructor's features param.

Just realized that corepack integration can be added. https://nodejs.org/api/packages.html#packagemanager.
This will simplify the package manager selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using yarn
4 participants