Skip to content

feat: add yarn/npm install to readme on yarn condition #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

feat: add yarn/npm install to readme on yarn condition #294

merged 2 commits into from
Mar 20, 2025

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Mar 26, 2022

@glensc glensc mentioned this pull request Mar 26, 2022
Open
@glensc
Copy link
Contributor Author

glensc commented Mar 29, 2022 •
edited
Loading

does the .option need to be declared? as it works without (as you can see jest test passes)

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 20, 2025
View reviewed changes
Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This LGTM as a first step before #293! cc @UlisesGascon to confirm, I don't think there are issues with adding this in before #293's this.option('yarn', ...) is added?

UlisesGascon
UlisesGascon approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon UlisesGascon moved this to In Progress in Maintenance Reboot Mar 20, 2025
@JoshuaKGoldberg JoshuaKGoldberg changed the title Add yarn/npm install to readme on yarn condition feat: add yarn/npm install to readme on yarn condition Mar 20, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 23512b7 into yeoman:main Mar 20, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Maintenance Reboot Mar 20, 2025
@glensc glensc deleted the yarn-readme-option branch March 24, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels

None yet

Projects

Maintenance Reboot
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glensc @JoshuaKGoldberg @UlisesGascon