windows: Fix keystroke & keymap #36572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
JunkuiZhang
force-pushed
the
windows/keystroke
branch
3 times, most recently
from
3816b1f to
c76ffd4
Compare
JunkuiZhang
force-pushed
the
windows/keystroke
branch
from
e08c2f8 to
144d110
Compare
Co-authored-by: Kate <[email protected]>
JunkuiZhang
force-pushed
the
windows/keystroke
branch
from
a34ffe7 to
98ea1d8
Compare
tidely
pushed a commit
to tidely/zed
that referenced
this pull request
Sep 10, 2025
Closes zed-industries#36300 This PR follows Windows conventions by introducing `KeybindingKeystroke`, so shortcuts now show up as `ctrl-shift-4` instead of `ctrl-$`. It also fixes issues with keyboard layouts: when `use_key_equivalents` is set to true, keys are remapped based on their virtual key codes. For example, `ctrl-\` on a standard English layout will be mapped to `ctrl-ё` on a Russian layout. Release Notes: - N/A --------- Co-authored-by: Kate <[email protected]>
This was referenced Sep 22, 2025
notpeter
added a commit
that referenced
this pull request
Sep 23, 2025
FrGoIs
pushed a commit
to FrGoIs/zed
that referenced
this pull request
Sep 29, 2025
Closes zed-industries#36300 This PR follows Windows conventions by introducing `KeybindingKeystroke`, so shortcuts now show up as `ctrl-shift-4` instead of `ctrl-$`. It also fixes issues with keyboard layouts: when `use_key_equivalents` is set to true, keys are remapped based on their virtual key codes. For example, `ctrl-\` on a standard English layout will be mapped to `ctrl-ё` on a Russian layout. Release Notes: - N/A --------- Co-authored-by: Kate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36300
This PR follows Windows conventions by introducing
KeybindingKeystroke, so shortcuts now show up asctrl-shift-4instead ofctrl-$.It also fixes issues with keyboard layouts: when
use_key_equivalentsis set to true, keys are remapped based on their virtual key codes. For example,ctrl-\on a standard English layout will be mapped toctrl-ёon a Russian layout.Release Notes: