Skip to content

feat: add setting to enable and disable suggested articles#771

Draft
melzreal wants to merge 3 commits intomasterfrom
melreal/hide-suggested-articles-setting
Draft

feat: add setting to enable and disable suggested articles#771
melzreal wants to merge 3 commits intomasterfrom
melreal/hide-suggested-articles-setting

Conversation

@melzreal
Copy link
Copy Markdown
Contributor

@melzreal melzreal commented Mar 6, 2026

Description

  1. Add setting to enable and disable suggested articles
  2. Update translations to pull the needed strings for the setting to display, by running yarn i18n:update-translations and yarn download-locales then committing the results

Jira: https://zendesk.atlassian.net/jira/software/c/projects/GG/boards/8177?selectedIssue=GG-4392&visitedUserSeg=true

Screenshots

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@melzreal melzreal force-pushed the melreal/hide-suggested-articles-setting branch from 8b3f29c to 66568f8 Compare March 6, 2026 13:27
@melzreal melzreal force-pushed the melreal/hide-suggested-articles-setting branch 2 times, most recently from 09ee472 to 0ed01e2 Compare March 23, 2026 16:56
@melzreal melzreal marked this pull request as ready for review March 23, 2026 17:12
@melzreal melzreal requested review from a team as code owners March 23, 2026 17:12
dmuneras
dmuneras previously approved these changes Mar 23, 2026
SirishaNeduri
SirishaNeduri previously approved these changes Mar 24, 2026
Copy link
Copy Markdown
Contributor

@Fredx87 Fredx87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is implemented in this PR is not what the Jira story says. The story is about

hiding Suggested Articles component in New request form

This PR and the added setting are instead referring to the suggested articles in the community post page. I guess we will need to submit a new string for the description and then wait again for the translations

@melzreal melzreal marked this pull request as draft March 24, 2026 09:50
@melzreal melzreal dismissed stale reviews from SirishaNeduri and dmuneras via f369df6 March 24, 2026 10:12
@melzreal
Copy link
Copy Markdown
Contributor Author

melzreal commented Mar 24, 2026

I guess we will need to submit a new string for the description

yes, I'm so sorry. I somehow misread the acceptance criteria and failed to notice the new request form part. Have opened #783 with the modified string

@melzreal melzreal force-pushed the melreal/hide-suggested-articles-setting branch 3 times, most recently from 96b6567 to 0152975 Compare April 1, 2026 10:18
@melzreal melzreal force-pushed the melreal/hide-suggested-articles-setting branch from 0152975 to 46c0220 Compare April 1, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants