sysbuild: Default to swap using offset for MCUboot #93310
Conversation
This swapping method is more efficient than swap using move and has been available for some time, remove experimental flag and set it as the default except for stm32 devices which have partition alignment for swap using move Signed-off-by: Jamie McCrae <[email protected]>
|
| config MCUBOOT_MODE_SWAP_USING_OFFSET | ||
| bool "Swap using offset" | ||
| select EXPERIMENTAL | ||
| help |
There was a problem hiding this comment.
Funnily this description isn't really helpful IMO. I would have expected to learn about the difference between USING_MOVE vs USING_OFFSET from the help texts. But they appear to be identical.
There was a problem hiding this comment.
The description is in MCUboot: https://github.com/mcu-tools/mcuboot/blob/main/boot/zephyr/Kconfig#L481
There was a problem hiding this comment.
Sure, but it wouldn't hurt refer to it.
There was a problem hiding this comment.
minor non-blocking comment, and also think this would be nice:
#93310 (comment)
| # Should be removed if board dts is updated | ||
| default MCUBOOT_MODE_SWAP_USING_MOVE if SOC_FAMILY_STM32 |
There was a problem hiding this comment.
would be nice if comment contains a bit more info, for example.
# default MCUBOOT_MODE_SWAP_USING_MOVE should be removed if STM32 board dts is updated
especially because sometimes when code gets updated then developers forget to remove the comment, making other people puzzled on the meaning of the comment.
btw. you mention board dts, but checks againts STM32 SoC.
Is this in the board dts for all STM32, or in a soc dts ?
Sorry @tejlmand - I only saw this after merging. I should have given @nordicjm a bit of time to address your comment. |
|
Introduced regression in tests:
|
JarmouniA
added
the
Release Notes Required
|
@nordicjm this major change should be detailed in the migration guide. |
9 participants
This swapping method is more efficient than swap using move and has been available for some time, remove experimental flag and set it as the default except for stm32 devices which have partition alignment for swap using move
FYI @erwango