sysbuild: Default to swap using offset for MCUboot #93310
+3
−2
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,9 @@ if BOOTLOADER_MCUBOOT | |
|
|
||
| choice MCUBOOT_MODE | ||
| prompt "Mode of operation" | ||
| # Should be removed if board dts is updated | ||
| default MCUBOOT_MODE_SWAP_USING_MOVE if SOC_FAMILY_STM32 | ||
| default MCUBOOT_MODE_SWAP_USING_OFFSET | ||
| help | ||
| The operating mode of MCUboot (which will also be propagated to the application). | ||
|
|
||
|
|
@@ -45,7 +47,6 @@ config MCUBOOT_MODE_SINGLE_APP | |
|
|
||
| config MCUBOOT_MODE_SWAP_USING_OFFSET | ||
| bool "Swap using offset" | ||
| help | ||
|
There was a problem hiding this comment. Funnily this description isn't really helpful IMO. I would have expected to learn about the difference between There was a problem hiding this comment. The description is in MCUboot: https://github.com/mcu-tools/mcuboot/blob/main/boot/zephyr/Kconfig#L481 There was a problem hiding this comment. Sure, but it wouldn't hurt refer to it. |
||
| MCUboot expects slot0_partition and slot1_partition to be present in DT and application | ||
| will boot from slot0_partition. MCUBOOT_BOOTLOADER_NO_DOWNGRADE should also be selected | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice if comment contains a bit more info, for example.
especially because sometimes when code gets updated then developers forget to remove the comment, making other people puzzled on the meaning of the comment.
btw. you mention board dts, but checks againts STM32 SoC.
Is this in the board dts for all STM32, or in a soc dts ?