Add Basic support for Microchip SAM D5X/E5X Family devices #93450

ArunMCHP · 2025-07-21T14:07:08Z

This PR adds initial support for Microchip’s SAM D5x/E5x family of SoCs, along with board support for the SAM E54 Xplained Pro development kit (ATSAME54-XPRO). It includes the basic SoC integration, devicetree files, and minimal configuration needed to bring up the board with a working UART console.

Associated pull request for the addition of the SAM D5x/E5x devices to hal_microchip:
zephyrproject-rtos/hal_microchip#33

The naming convention of driver files and device organization is as per the RFC : #92168

github-actions · 2025-07-21T14:07:59Z

Hello @ArunMCHP, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

github-actions · 2025-07-21T14:08:58Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_microchip	zephyrproject-rtos/hal_microchip@`415c92d`	zephyrproject-rtos/hal_microchip@`2c5eb6b` (`master`)	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

soc/microchip/sam/sam_d5x_e5x/Kconfig.soc

soc/microchip/sam/sam_d5x_e5x/samd51/Kconfig.soc

drivers/pinctrl/Kconfig.mchp

drivers/serial/Kconfig.mchp

boards/microchip/sam/sam_e54_xpro/doc/img/atsam_e54_xpro.webp

boards/microchip/sam/sam_e54_xpro/doc/img/atsam_e54_xpro_pinout.webp

parthitce

Please re-order the commits.

soc/microchip/sam/sam_d5x_e5x/Kconfig.soc

soc/microchip/sam/sam_d5x_e5x/common/CMakeLists.txt

soc/microchip/sam/sam_d5x_e5x/common/soc.c

drivers/clock_control/clock_mchp_sam_d5x_e5x.c

drivers/clock_control/Kconfig.mchp

drivers/clock_control/clock_mchp_sam_d5x_e5x.c

kartben

Some minor problems spotted in the documentation page of the new board

Thanks!

kartben · 2025-08-06T07:33:59Z

boards/microchip/sam/sam_e54_xpro/doc/index.rst

+SAM E54 Xplained Pro Evaluation Kit
+###################################
+


Suggested change

SAM E54 Xplained Pro Evaluation Kit

###################################

kartben · 2025-08-06T07:34:20Z

boards/microchip/sam/sam_e54_xpro/doc/index.rst

+
+.. image:: img/atsam_e54_xpro.webp
+     :align: center
+     :alt: SAM_E54_XPRO


Suggested change

.. image:: img/atsam_e54_xpro.webp

:align: center

:alt: SAM_E54_XPRO

kartben · 2025-08-06T07:35:34Z

boards/microchip/sam/sam_e54_xpro/doc/index.rst

+
+.. image:: img/atsam_e54_xpro_pinout.webp
+     :align: center
+     :alt: SAME54-XPRO-pinout


Suggested change

.. image:: img/atsam_e54_xpro_pinout.webp

:align: center

:alt: SAME54-XPRO-pinout

Please drop this image file. It adds no useful information

kartben · 2025-08-06T07:35:51Z

boards/microchip/sam/sam_e54_xpro/doc/index.rst

+Default Zephyr Peripheral Mapping:
+----------------------------------
+- SERCOM2 USART TX : PB24


Suggested change

Default Zephyr Peripheral Mapping:

----------------------------------

- SERCOM2 USART TX : PB24

Default Zephyr Peripheral Mapping

---------------------------------

- SERCOM2 USART TX : PB24

kartben · 2025-08-06T07:37:04Z

boards/microchip/sam/sam_e54_xpro/doc/index.rst

+- SERCOM2 USART TX : PB24
+- SERCOM2 USART RX : PB25
+- GPIO/PWM LED0    : PC18
+- GPIO SW0         : PB31
+- GMAC RMII REFCK  : PA14
+- GMAC RMII TXEN   : PA17
+- GMAC RMII TXD0   : PA18
+- GMAC RMII TXD1   : PA19
+- GMAC RMII CRSDV  : PC20
+- GMAC RMII RXD0   : PA13
+- GMAC RMII RXD1   : PA12
+- GMAC RMII RXER   : PA15
+- GMAC MDIO MDC    : PC11
+- GMAC MDIO MDIO   : PC12
+- SERCOM4 SPI SCK  : PB26
+- SERCOM4 SPI MOSI : PB27
+- SERCOM4 SPI MISO : PB29
+- SERCOM7 I2C SDA  : PD08
+- SERCOM7 I2C SCL  : PD09
+- USB DP           : PA25
+- USB DM           : PA24


You may want to make this a table -- your manual semicolon alignment are lost in html form (but it can also stay like this, your call)

https://builds.zephyrproject.io/zephyr/pr/93450/docs/boards/microchip/sam/sam_e54_xpro/doc/index.html#default-zephyr-peripheral-mapping

Thanks @kartben, We have removed this section and given reference to board user guide.

kartben · 2025-08-06T07:38:06Z

boards/microchip/sam/sam_e54_xpro/doc/img/atsam_e54_xpro.webp

Convention is to name the file exactly the same as the board

Renamed same as board name.

kartben

Also note that you may want to refrain from using the word "binding" in the description of the bindings you're introducing, and may want to look at adding a concise title: property which is what will get picked up for the autogenerated list of supported hardware features
https://docs.zephyrproject.org/latest/boards/microchip/sam/sama7g54_ek/doc/index.html#supported-features

Add clock dts node and minimal set of binding parameters for clock_control driver. Signed-off-by: Sunil Abraham <[email protected]>

Add clock control driver with minimal functionality. Implement basic on, off, get_status and get_rate API. Signed-off-by: Sunil Abraham <[email protected]>

Add pinctrl dts node and binding parameters for Microchip Pinctrl Port G1 IP Signed-off-by: Mohamed Azhar <[email protected]>

Add pinctrl driver for Microchip Port G1 Peripheral IPs Signed-off-by: Mohamed Azhar <[email protected]>

Add uart dts nodes and minimal set of binding parameters for sercom uart driver. Signed-off-by: Sunil Abraham <[email protected]>

Add uart driver with minimal features. Implement polling receive and transmit functionality. Signed-off-by: Sunil Abraham <[email protected]>

ArunMCHP · 2025-08-06T14:52:30Z

Also note that you may want to refrain from using the word "binding" in the description of the bindings you're introducing, and may want to look at adding a concise title: property which is what will get picked up for the autogenerated list of supported hardware features https://docs.zephyrproject.org/latest/boards/microchip/sam/sama7g54_ek/doc/index.html#supported-features

Thanks @kartben. We have added a title to each binding we introduced and also removed the word "binding" from the description section.

We have addressed all the review comments, kindly review and merge the PR if everything looks good.

kartben · 2025-08-07T18:39:21Z

boards/microchip/sam/sam_e54_xpro/doc/index.rst

+Follow these steps to program and debug the board:
+==================================================
+


This seems unnecessary, you're already in the Programming and Debugging section

Suggested change

Follow these steps to program and debug the board:

==================================================

Thanks @kartben. I will remove this and update the PR.

Removed these lines.

Add initial support for the Microchip SAM E54 Xplained Pro board (ATSAME54-XPRO). Product page: https://www.microchip.com/en-us/development-tool/atsame54-xpro Signed-off-by: Arunprasath P <[email protected]>

ArunMCHP · 2025-08-08T04:59:51Z

Hi @kartben,
Thank you for your valuable feedback. We’ve addressed your previous comment, kindly re-review and approve the PR when convenient.

Hi @parthitce, @nordicjm , @nandojve,
Thanks again for your earlier reviews and approvals. Since we’ve made documentation updates based on @kartben comments, we kindly request your re-approval on the updated PR.

github-actions · 2025-08-08T08:53:07Z

Hi @ArunMCHP!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

zephyrbot added platform: Microchip SAM Microchip SAM Platform (formerly Atmel SAM) area: Pinctrl area: Flash area: UART Universal Asynchronous Receiver-Transmitter labels Jul 21, 2025

zephyrbot added area: Clock Control platform: Microchip MEC Microchip MEC Platform labels Jul 21, 2025

zephyrbot requested review from albertofloyd, dcpleung, de-nordic, gmarull, jvasanth1, mnkp, nandojve, nordic-krch, pdgendt, rghaddab, stephanosio and VenkatKotakonda July 21, 2025 14:08

zephyrbot assigned nordic-krch Jul 21, 2025

github-actions bot added manifest manifest-hal_microchip DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 21, 2025

nordicjm requested changes Jul 22, 2025

View reviewed changes

ArunMCHP force-pushed the sam_d5x_e5x_minimal_support branch from 5e8b12a to 4981667 Compare July 22, 2025 14:19

ArunMCHP requested a review from nordicjm July 22, 2025 14:37

parthitce requested changes Jul 23, 2025

View reviewed changes

ArunMCHP force-pushed the sam_d5x_e5x_minimal_support branch 2 times, most recently from 5b8d763 to eac3759 Compare July 23, 2025 18:04

kartben unassigned nordic-krch Aug 6, 2025

kartben requested changes Aug 6, 2025

View reviewed changes

kartben reviewed Aug 6, 2025

View reviewed changes

sunil-abraham and others added 6 commits August 6, 2025 19:14

dts: arm: microchip: add clock dts node and bindings for SAM D5x/E5x

d45c3d3

Add clock dts node and minimal set of binding parameters for clock_control driver. Signed-off-by: Sunil Abraham <[email protected]>

drivers: clock_control: microchip: clock support for SAM D5x/E5x

cd887b8

Add clock control driver with minimal functionality. Implement basic on, off, get_status and get_rate API. Signed-off-by: Sunil Abraham <[email protected]>

dts: arm: microchip: add pinctrl dts node and bindings for Port G1 IP

aec748f

Add pinctrl dts node and binding parameters for Microchip Pinctrl Port G1 IP Signed-off-by: Mohamed Azhar <[email protected]>

drivers: pinctrl: microchip: add pinctrl driver for Port G1 IP

71b67fd

Add pinctrl driver for Microchip Port G1 Peripheral IPs Signed-off-by: Mohamed Azhar <[email protected]>

dts: arm: microchip: add uart dts node and bindings for sercom g1 IPs

83e1a1a

Add uart dts nodes and minimal set of binding parameters for sercom uart driver. Signed-off-by: Sunil Abraham <[email protected]>

drivers: uart: microchip: add minimal support for sercom uart g1 IPs

42cec09

Add uart driver with minimal features. Implement polling receive and transmit functionality. Signed-off-by: Sunil Abraham <[email protected]>

ArunMCHP dismissed stale reviews from nordicjm, parthitce, and nandojve via 3688ddd August 6, 2025 14:39

ArunMCHP force-pushed the sam_d5x_e5x_minimal_support branch from 1bc7d79 to 3688ddd Compare August 6, 2025 14:39

ArunMCHP requested a review from kartben August 7, 2025 16:29

kartben previously approved these changes Aug 7, 2025

View reviewed changes

boards: microchip: add SAM E54 Xplained Pro board support

c7a6b8a

Add initial support for the Microchip SAM E54 Xplained Pro board (ATSAME54-XPRO). Product page: https://www.microchip.com/en-us/development-tool/atsame54-xpro Signed-off-by: Arunprasath P <[email protected]>

ArunMCHP dismissed kartben’s stale review via c7a6b8a August 8, 2025 04:57

ArunMCHP force-pushed the sam_d5x_e5x_minimal_support branch from 3688ddd to c7a6b8a Compare August 8, 2025 04:57

ArunMCHP requested a review from kartben August 8, 2025 05:00

kartben approved these changes Aug 8, 2025

View reviewed changes

parthitce approved these changes Aug 8, 2025

View reviewed changes

nandojve approved these changes Aug 8, 2025

View reviewed changes

nandojve requested a review from nordicjm August 8, 2025 08:29

nordicjm approved these changes Aug 8, 2025

View reviewed changes

jhedberg merged commit 8d44550 into zephyrproject-rtos:main Aug 8, 2025
26 checks passed

ArunMCHP deleted the sam_d5x_e5x_minimal_support branch August 11, 2025 06:45

ArunMCHP restored the sam_d5x_e5x_minimal_support branch August 11, 2025 06:50

		SAM E54 Xplained Pro Evaluation Kit
		###################################

		Follow these steps to program and debug the board:
		==================================================

Add Basic support for Microchip SAM D5X/E5X Family devices #93450

Add Basic support for Microchip SAM D5X/E5X Family devices #93450

Uh oh!

Conversation

ArunMCHP commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

github-actions bot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

parthitce left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kartben left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartben left a comment

Choose a reason for hiding this comment

Uh oh!

ArunMCHP commented Aug 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ArunMCHP commented Aug 8, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 8, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 21, 2025 •

edited

Loading