Skip to content

Silabs DTS format #93810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2025
Merged

Silabs DTS format #93810

merged 2 commits into from
Jul 31, 2025

Conversation

yishai1999
Copy link
Contributor

@yishai1999 yishai1999 commented Jul 29, 2025 •
edited
Loading

Formatted Silabs DTS files:

asmellby
asmellby reviewed Jul 29, 2025
View reviewed changes
Copy link
Contributor

@asmellby asmellby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Found one typo.

@yishai1999
dts: silabs: make sram definition consistant
60fc4bd 
Made the definition of sram in the dtsi consistant across the socs.

Signed-off-by: Yishai Jaffe <[email protected]>
@asmellby asmellby mentioned this pull request Jul 29, 2025
Merged
@yishai1999 yishai1999 requested a review from asmellby July 29, 2025 11:19
@Martinhoff-maker
Copy link
Contributor

Nice! It might be a minor miss but 3 other boards use #include <dt-bindings/pinctrl/silabs/xg24-pinctrl.h>:

  • Arduino nano matter
  • xiao_mg24
  • sparkfun_thing_plus_matter

I think we need to update those as well.

@yishai1999
Copy link
Contributor Author

Nice! It might be a minor miss but 3 other boards use #include <dt-bindings/pinctrl/silabs/xg24-pinctrl.h>:

  • Arduino nano matter
  • xiao_mg24
  • sparkfun_thing_plus_matter

I think we need to update those as well.

No problem

@yishai1999
dts: silabs: migrate includes to <zephyr/...>
958d8cf 
In order to bring consistency in-tree, migrate all dts code to the new
prefix <zephyr/...>. Refer to zephyrproject-rtos#45388 for more details.

Signed-off-by: Yishai Jaffe <[email protected]>
@zephyrbot zephyrbot added the platform: Seeed Studio Seeed Studio platforms label Jul 29, 2025
@zephyrbot zephyrbot requested review from facchinm and pillo79 July 29, 2025 15:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@asmellby asmellby mentioned this pull request Jul 30, 2025
Open
@cfriedt cfriedt merged commit 9470cd0 into zephyrproject-rtos:main Jul 31, 2025
28 checks passed
@yishai1999 yishai1999 deleted the silabs-dts-format branch July 31, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmellby asmellby asmellby approved these changes

@Martinhoff-maker Martinhoff-maker Martinhoff-maker approved these changes

@gmarull gmarull Awaiting requested review from gmarull

@jerome-pouiller jerome-pouiller Awaiting requested review from jerome-pouiller

@jhedberg jhedberg Awaiting requested review from jhedberg

@M1cha M1cha Awaiting requested review from M1cha

@rettichschnidi rettichschnidi Awaiting requested review from rettichschnidi

@facchinm facchinm Awaiting requested review from facchinm

@pillo79 pillo79 Awaiting requested review from pillo79

Assignees

@jhedberg jhedberg

@asmellby asmellby

Labels
area: Pinctrl platform: Seeed Studio Seeed Studio platforms platform: Silabs SiM3U Silicon Labs SiM3U platform: Silabs Silicon Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yishai1999 @Martinhoff-maker @asmellby @cfriedt @jhedberg @zephyrbot