low cost power shield solution #95056

hakehuang · 2025-08-27T11:24:06Z

Create adc_power_shield sample for any board with adc can be used for power measurement.
Add general_adc_platform power shiled, which can be used for power measurement with the sample application.
the power data is stored in the power_shield folder for further analysis
add power measure config in testsuite.

hakehuang · 2025-08-27T11:25:03Z

log for mimxrt595_evk board

((.venv) ) ubuntu@ubuntu-OptiPlex-7050:/home/shared/disk/zephyr_project/zephyr_test/zephyr$ scripts/twister --device-testing --hardware-map /home/ubuntu/nxp/mimxrt595_evk_cm33/map.yaml -T samples/boards/nxp/mimxrt595_evk/system_off
ZEPHYR_BASE unset, using "/home/shared/disk/zephyr_project/zephyr_test/zephyr"
Renaming previous output directory to /home/shared/disk/zephyr_project/zephyr_test/zephyr/twister-out.1
INFO    - Using Ninja..
INFO    - Zephyr version: v4.2.0-2411-g0f6f916cbaa4
INFO    - Using 'zephyr' toolchain.
INFO    - Building initial testsuite list...
INFO    - Writing JSON report /home/shared/disk/zephyr_project/zephyr_test/zephyr/twister-out/testplan.json

Device testing on:

| Platform                      |        ID | Serial device                                         |
|-------------------------------|-----------|-------------------------------------------------------|
| mimxrt595_evk/mimxrt595s/cm33 | 727562924 | /dev/serial/by-id/usb-SEGGER_J-Link_000727562924-if00 |

INFO    - JOBS: 8
INFO    - Adding tasks to the queue...
INFO    - Added initial list of jobs to queue
INFO    - Total complete:    1/   1  100%  built (not run):    0, filtered:    0, failed:    0, error:    0
INFO    - 1 test scenarios (1 configurations) selected, 0 configurations filtered (0 by static filter, 0 at runtime).
INFO    - 1 of 1 executed test configurations passed (100.00%), 0 built (not run), 0 failed, 0 errored, with no warnings in 29.99 seconds.
INFO    - 1 of 1 executed test cases passed (100.00%) on 1 out of total 1154 platforms (0.09%).
INFO    - 1 test configurations executed on platforms, 0 test configurations were only built.

JarmouniA · 2025-08-27T11:52:20Z

samples/drivers/adc/adc_power_shield/sample.yaml

Please take a look at #94585, and only keep 1 platform per vendor.

thanks @JarmouniA PR #94585 looks good, I will update according after your PR merged

There is no need to wait for it to be merged, just apply the same filtering and only keep overlay/conf of 1 platform per vendor in the new sample.

nordicjm · 2025-08-27T12:49:21Z

samples/drivers/adc/adc_power_shield/Kconfig

+
+config SEQUENCE_32BITS_REGISTERS
+	bool "ADC data sequences are on 32bits"
+	default n


Suggested change

default n

samples/drivers/adc/adc_power_shield/boards/arduino_due.overlay

samples/drivers/adc/adc_power_measure/boards/frdm_mcxc444.overlay

nordicjm · 2025-08-27T12:50:35Z

samples/drivers/adc/adc_power_shield/boards/s32k148_evb.overlay

+	pinctrl-0 = <&adc0_default>;
+	pinctrl-names = "default";


move above child node

samples/drivers/adc/adc_power_shield/boards/s32z2xxdc2_s32z270_rtu0.overlay

hakehuang · 2025-10-03T02:19:37Z

We already have a twister harness for the shell, can it not be reused? and regarding the specific ADC channel, that can be added in an overlay when building surely, like this PR is already doing? We can also add a custom shell command to use specifically if needed, no need to implement command line parsing in the sample

@bjarki-andreasen if you look at my PR, I add a 'dft' which reuse the whole pytest serial handler see

zephyr/scripts/pylib/power-twister-harness/conftest.py

Line 130 in 815f2b6

    
           def dft(request: pytest.FixtureRequest, dft_object) -> Generator[DeviceAdapter, None, None]:

. ADC channel is already controlled by overlay, but the problem is that we need map the channel to the target power rails see below definition:
the channels_p and channel_n to the power rail "VDD_CORE" / "VDD_IO" is by your board setting definition, this could be different pre your test harness setting, and this has to be customized, here is use a yaml to control it.

device_id: "adc_power_monitor_01"
routes:
  - id: 0
    name: "VDD_CORE"
    shunt_resistor: 0.1  # ohms
    gain: 1.0
    type: "single"
    channels:
      channels_p: 4
      channels_n: 0
  - id: 1
    name: "VDD_IO"
    shunt_resistor: 0.1  # ohms
    gain: 1.0
    type: "single"
    channels:
      channels_p: 7
      channels_n: 3
calibration:
  offset: 0.0
  scale: 1.0

so nowhat where to add, we either add shell command or use a dedicated power shield sample application, we have to parse the shell/command output to get the board settings on its probe capacities, see below.

{
  "channel_count": 2,
  "resolution": 12,
  "channels": {
    "0": {
      "mode": "single",
      "verf_mv": 3300
    },
    "3": {
      "mode": "single",
      "verf_mv": 3300
    },
    "4": {
      "mode": "single",
      "verf_mv": 3300
    },
    "7": {
      "mode": "single",
      "verf_mv": 3300
    }
  }
}

and we need map the probe capacities to the target measure power rails as I mentioned above. My understanding is that you propose to use a series of shell command to replace the power measure sample which will be running on power shield. this will add adc shell linked with power calculations I am not sure this will accepted by ADC shell owner? As in this PR, we have an independent sample to host everything, move those to shell command needs approval, can you help to confirm on my understanding and if accepted by ADC shell group I can move the implement to shell.

bjarki-andreasen · 2025-10-04T06:41:48Z

We already have a twister harness for the shell, can it not be reused? and regarding the specific ADC channel, that can be added in an overlay when building surely, like this PR is already doing? We can also add a custom shell command to use specifically if needed, no need to implement command line parsing in the sample

@bjarki-andreasen if you look at my PR, I add a 'dft' which reuse the whole pytest serial handler see

zephyr/scripts/pylib/power-twister-harness/conftest.py

Line 130 in 815f2b6

def dft(request: pytest.FixtureRequest, dft_object) -> Generator[DeviceAdapter, None, None]:

. ADC channel is already controlled by overlay, but the problem is that we need map the channel to the target power rails see below definition:
the channels_p and channel_n to the power rail "VDD_CORE" / "VDD_IO" is by your board setting definition, this could be different pre your test harness setting, and this has to be customized, here is use a yaml to control it.
device_id: "adc_power_monitor_01"
routes:
  - id: 0
    name: "VDD_CORE"
    shunt_resistor: 0.1  # ohms
    gain: 1.0
    type: "single"
    channels:
      channels_p: 4
      channels_n: 0
  - id: 1
    name: "VDD_IO"
    shunt_resistor: 0.1  # ohms
    gain: 1.0
    type: "single"
    channels:
      channels_p: 7
      channels_n: 3
calibration:
  offset: 0.0
  scale: 1.0
so nowhat where to add, we either add shell command or use a dedicated power shield sample application, we have to parse the shell/command output to get the board settings on its probe capacities, see below.
{
  "channel_count": 2,
  "resolution": 12,
  "channels": {
    "0": {
      "mode": "single",
      "verf_mv": 3300
    },
    "3": {
      "mode": "single",
      "verf_mv": 3300
    },
    "4": {
      "mode": "single",
      "verf_mv": 3300
    },
    "7": {
      "mode": "single",
      "verf_mv": 3300
    }
  }
}
and we need map the probe capacities to the target measure power rails as I mentioned above. My understanding is that you propose to use a series of shell command to replace the power measure sample which will be running on power shield. this will add adc shell linked with power calculations I am not sure this will accepted by ADC shell owner? As in this PR, we have an independent sample to host everything, move those to shell command needs approval, can you help to confirm on my understanding and if accepted by ADC shell group I can move the implement to shell.

No changes to the adc shell is needed. We would just create a set of custom shell commands as part of the power shield sample. The issue is not with having a sample at all, we need that, but with how the serial communication is implemented. We can freely create sample specific shell commands, so why not use that?

hakehuang · 2025-10-05T01:57:27Z

No changes to the adc shell is needed. We would just create a set of custom shell commands as part of the power shield sample. The issue is not with having a sample at all, we need that, but with how the serial communication is implemented. We can freely create sample specific shell commands, so why not use that?

ok, I see, I will update this PR to add a sample specific shell command. but I have some concerns on the code size, I enable the stm32f030dlk as the low cost shield, which code size is very critical. Let me try and feedback.

bjarki-andreasen · 2025-10-06T06:59:53Z

No changes to the adc shell is needed. We would just create a set of custom shell commands as part of the power shield sample. The issue is not with having a sample at all, we need that, but with how the serial communication is implemented. We can freely create sample specific shell commands, so why not use that?

ok, I see, I will update this PR to add a sample specific shell command. but I have some concerns on the code size, I enable the stm32f030dlk as the low cost shield, which code size is very critical. Let me try and feedback.

For this, enable SHELL_MINIMAL, the entire shell should "only" take up 6-8K ROM, if that is too much we may have to go with a custom solution

bjarki-andreasen · 2025-10-09T17:50:59Z

subsys/pm/Kconfig

+config ENABLE_PM_MEASURE
+	bool "System Power Measure"
+	depends on SYS_CLOCK_EXISTS && HAS_PM
+	help
+	  This option enables measurement on target power state
+


These options do not belong with the subsystem, add them to the tests and/or samples where they are used

@bjarki-andreasen , I move those options to testsuite config. is it OK?

add power measure sample for general_adc_platform power shiled, to record power/voltage/current Signed-off-by: Hake Huang <[email protected]>

1. general power shield work with the adc_power_shield sample 2. config samples to config probe 3. add readme 4. enable parse shell command outputs, see readme for details Signed-off-by: Hake Huang <[email protected]>

enable power shield testing on mimxrt595_evk ``` scripts/twister --device-testing --device-serial /dev/ttyACM0 -T samples/boards/nxp/mimxrt595_evk/system_off -X pm_probe:/dev/ttyACM1,115200 ``` an power_shield folder will be created in the build path whith measured voltage/current/power Signed-off-by: Hake Huang <[email protected]>

enable power measure on power_mgmt_soc for mimxrt1060_evk@C Signed-off-by: Hake Huang <[email protected]>

add power measure options to test Signed-off-by: Hake Huang <[email protected]>

demo the power measure with frdm_rw612 boards keep the system in final power state for measurement Signed-off-by: Hake Huang <[email protected]>

sonarqubecloud · 2025-10-13T09:51:14Z

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bjarki-andreasen

I'm surprised how much python code is needed to make this work

hakehuang · 2025-10-14T02:32:04Z

I'm surprised how much python code is needed to make this work

@bjarki-andreasen, I want to make the adc_power_measure case simple, and move the complex things to python for easy change.
I update the pull-request description, please help to re-review again. Besides, I find there are some interrupt alignment issue with libc settings when I try to add CONFIG_GEN_SW_ISR_TABLE=n to reduce the code size. will follow up with another issue. Please help to review the pr description. Thanks a lot.

just realize that you have approved, and sorry for re-request review. My hand acts without thinking.

bjarki-andreasen · 2025-10-14T10:06:29Z

I'm surprised how much python code is needed to make this work

@bjarki-andreasen, I want to make the adc_power_measure case simple, and move the complex things to python for easy change. I update the pull-request description, please help to re-review again. Besides, I find there are some interrupt alignment issue with libc settings when I try to add CONFIG_GEN_SW_ISR_TABLE=n to reduce the code size. will follow up with another issue.

CONFIG_GEN_SW_ISR_TABLE=n is not a commonly supported option, it requires CONFIG_MULTITHREADING=n and/or rewrites of IRQ handling in drivers, and is only applicable for some archs.

Please help to review the pr description. Thanks a lot.

just realize that you have approved, and sorry for re-request review. My hand acts without thinking.

No problem

hakehuang · 2025-10-15T03:47:54Z

@kartben I update the sample application readme and reduce them to platforms that I tested. Please take a look. Thanks,

hakehuang · 2025-10-15T03:49:17Z

CONFIG_GEN_SW_ISR_TABLE=n is not a commonly supported option, it requires CONFIG_MULTITHREADING=n and/or rewrites of IRQ handling in drivers, and is only applicable for some archs.

@bjarki-andreasen , I see. thanks a lot for this comments, I will drop the trier with CONFIG_GEN_SW_ISR_TABLE=n. Please help to approve the PR again. Thanks a lot.

zephyrbot added area: ADC Analog-to-Digital Converter (ADC) platform: NXP NXP area: Twister Twister area: Samples Samples labels Aug 27, 2025

zephyrbot requested review from DerekSnell, EmilioCBen, JarmouniA, KamilxPaszkiet, LukaszMrugala, PerMac, anangl, butok, decsny, dleach02, gchwier, golowanow, kartben, mmahadevan108 and nashif August 27, 2025 11:25

zephyrbot assigned kartben Aug 27, 2025

hakehuang force-pushed the lc_power_shield branch 4 times, most recently from 59e3ca2 to 8f0f3f4 Compare August 27, 2025 12:24

JarmouniA reviewed Aug 27, 2025

View reviewed changes

nordicjm previously requested changes Aug 27, 2025

View reviewed changes

hakehuang marked this pull request as draft August 28, 2025 03:32

hakehuang force-pushed the lc_power_shield branch 2 times, most recently from c19dcd6 to 78d25a9 Compare August 28, 2025 05:03

hakehuang marked this pull request as draft October 5, 2025 01:57

hakehuang force-pushed the lc_power_shield branch from 815f2b6 to 5d04eb9 Compare October 9, 2025 16:34

bjarki-andreasen requested changes Oct 9, 2025

View reviewed changes

hakehuang force-pushed the lc_power_shield branch 5 times, most recently from c1127b5 to fba939c Compare October 13, 2025 08:27

hakehuang added 4 commits October 13, 2025 16:37

samples: adc: add power measure application

3de9ae3

add power measure sample for general_adc_platform power shiled, to record power/voltage/current Signed-off-by: Hake Huang <[email protected]>

tests: scripts: add general power shield support

7519826

1. general power shield work with the adc_power_shield sample 2. config samples to config probe 3. add readme 4. enable parse shell command outputs, see readme for details Signed-off-by: Hake Huang <[email protected]>

tests: pm: power_mgmt_soc: enable measurement on rt1060

676f639

enable power measure on power_mgmt_soc for mimxrt1060_evk@C Signed-off-by: Hake Huang <[email protected]>

hakehuang force-pushed the lc_power_shield branch from fba939c to e9a5f47 Compare October 13, 2025 08:38

hakehuang added 2 commits October 13, 2025 17:28

testsuite: option: add power measure option to test

13bacd1

add power measure options to test Signed-off-by: Hake Huang <[email protected]>

tests: pm: power_residency_time: add power measure check

df5582f

demo the power measure with frdm_rw612 boards keep the system in final power state for measurement Signed-off-by: Hake Huang <[email protected]>

hakehuang force-pushed the lc_power_shield branch from e9a5f47 to df5582f Compare October 13, 2025 09:31

hakehuang marked this pull request as ready for review October 13, 2025 10:14

zephyrbot added the area: Testsuite Testsuite label Oct 13, 2025

zephyrbot requested a review from bjarki-andreasen October 13, 2025 10:16

bjarki-andreasen approved these changes Oct 13, 2025

View reviewed changes

hakehuang requested a review from bjarki-andreasen October 14, 2025 02:26

low cost power shield solution #95056

Are you sure you want to change the base?

low cost power shield solution #95056

Conversation

hakehuang commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hakehuang commented Aug 27, 2025

Uh oh!

JarmouniA Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

hakehuang Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

JarmouniA Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

nordicjm Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nordicjm Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hakehuang commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjarki-andreasen commented Oct 4, 2025

Uh oh!

hakehuang commented Oct 5, 2025

Uh oh!

bjarki-andreasen commented Oct 6, 2025

Uh oh!

bjarki-andreasen Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

hakehuang Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 13, 2025

Quality Gate passed

Uh oh!

bjarki-andreasen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hakehuang commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjarki-andreasen commented Oct 14, 2025

Uh oh!

hakehuang commented Oct 15, 2025

Uh oh!

hakehuang commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

hakehuang commented Aug 27, 2025 •

edited

Loading

hakehuang commented Oct 3, 2025 •

edited

Loading

hakehuang Oct 10, 2025 •

edited

Loading

bjarki-andreasen left a comment •

edited

Loading

hakehuang commented Oct 14, 2025 •

edited

Loading