Repository navigation
feat(ubtb): remove takenCnt & valid field - #5157
Merged
Merged
Conversation
ngc7331
force-pushed
the
feat-ubtb-remove-takencnt
branch
2 times, most recently
from
October 31, 2025 07:29
86dddb7 to
56ae437
Compare
ngc7331
marked this pull request as ready for review
November 1, 2025 06:31
Member
Author
|
CI IPC has increased both with/without fastTrain (#5145) IPC report w/o #5145
IPC report w/ #5145
|
|
[Generated by IPC robot]
kunminghu-v3 branch:
|
rich-cake
approved these changes
Nov 3, 2025
rich-cake
pushed a commit
that referenced
this pull request
Dec 1, 2025
- `TakenCnt` is removed in #5157, but I forgot to delete its parameter - no behaviour change now as `instOffsetBits = 1` when HasCExtension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only train taken branches into ubtb, if it's not taken, it's not useful. So
usefulCntis some sort oftakenCnt. Therefore, we can removetakenCntand do an always-taken prediction in ubtb.This also allows non-taken branches to be evicted earlier and thus we can use abtb/fallthrough results, so maybe has some performance gain.
We can also remove valid as it should always be
usefulCnt != 0