refactor(preview_panel): mvc split #952
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
the
Type: Refactor
|
Should be ready for review now |
8 tasks
8 tasks
CyanVoxel
reviewed
Jul 8, 2025
There was a problem hiding this comment.
Great work on this! Everything looks good for the most part, just found one bug with the preview panel - when updating the name of a tag, visually it doesn't update and instead throws this error:
Traceback (most recent call last):
File "/Users/cyanvoxel/Files/GitHub/TagStudio/src/tagstudio/qt/view/widgets/preview_panel_view.py", line 145, in set_selection
if len(selected) == 0:
^^^^^^^^^^^^^
TypeError: object of type 'bool' has no len()
|
fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Splits the current preview panel into View and Controller in accordance with the proposal in #950.
Tasks Completed