Add multi-file support to podman kube play/down
#27292
Conversation
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Honny1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: axel7083 <[email protected]> fix: update kube play command cobra use Signed-off-by: axel7083 <[email protected]> Add multi-file support to podman kube play/down - Support multiple YAML files and URLs in single command - Combine files with YAML document separators (---) - Refactor for better testability with dependency injection - Update documentation with examples for multiple inputs - Improve memory efficiency with streaming I/O operations Fixes: containers#26274 Fixes: https://issues.redhat.com/browse/RUN-3586 Signed-off-by: Jan Rodák <[email protected]>
Honny1
force-pushed
the
pr-multi-file-support-kube
branch
from
80a686e to
45988c5
Compare
|
cc @axel7083 |
|
The CI is failing due to an unrelated test: |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| } | ||
| return response.Body, nil | ||
| default: | ||
| return os.Open(fileName) |
There was a problem hiding this comment.
It just struck me that we're using http.Get() and I don't think we've set it to use TLS? Should we? Also, can this Get ever hang and never timeout?
There was a problem hiding this comment.
It should automatically use TLS. I'm not sure about the request timeout, though. I just reused the same function as before, which we're already using in multiple places. Is this considered bad practice in Go?
|
A couple of questions for consideration. |
| reader = f | ||
|
|
||
| if i < len(args)-1 { | ||
| combined.WriteString("\n---\n") |
There was a problem hiding this comment.
Please add a comment on top that this is file seperator ? Maybe also have \n---\n in a const string
4 participants
This PR enables
podman kube playandpodman kube downto accept multiple YAML files and URLs in a single command.Fixes: #26274
Fixes: https://issues.redhat.com/browse/RUN-3586
Does this PR introduce a user-facing change?