Skip to content

Tab manager update: Replace FABs with buttons #6384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

0nko
Copy link
Member

@0nko 0nko commented Jul 14, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1210543205190057?focus=true

Description

This PR hides the FABs and replaces them with toolbar buttons (NTP, Duck.ai).

Steps to test this PR

Normal mode

  • Go to the tab manager
  • Verify the FABs are gone
  • Verify the layout button is gone (will be added to the menu later)
  • Verify the Duck.ai and NTP buttons are visible
  • Tap on the menu button
  • Verify thew Net tab and Duck.ai menu items are gone
  • Check that the new toolbar buttons are functional

Selection Mode

  • Go to tab manager -> Tap on the Menu button -> Tap Select Tabs
  • Verify all toolbar buttons are hidden
  • Tap one the Menu button
  • Verify Select All option is visible
  • Tap on the Select All menu item
  • Verify the toolbar buttons are still hidden
  • Exit the selection mode
  • Verify the Duck.ai and NTP buttons are visible now

Copy link
Member Author

0nko commented Jul 14, 2025

@0nko 0nko changed the title Remove the FABs Tab manager update: Replace FABs with buttons Jul 14, 2025
@0nko 0nko marked this pull request as ready for review July 14, 2025 09:03
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-bottom-toolbar branch from b41e705 to 3349704 Compare July 18, 2025 12:13
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-buttons branch from 7da90cb to 16b112e Compare July 18, 2025 12:13
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-buttons branch from a633599 to 15c1363 Compare July 21, 2025 08:37
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-bottom-toolbar branch from 3349704 to 83a0c10 Compare July 21, 2025 08:37
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-buttons branch from 15c1363 to 6d435f4 Compare July 21, 2025 09:13
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but keyboard needs to be hidden when going to Duck.ai

@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-buttons branch from d151923 to c5d20b3 Compare July 21, 2025 10:47
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-bottom-toolbar branch from 3c1febc to 7479929 Compare July 21, 2025 10:48
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-buttons branch from c5d20b3 to 0c39eda Compare July 21, 2025 10:48
@0nko 0nko requested a review from joshliebe July 21, 2025 10:49
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected now 👍

Base automatically changed from feature/ondrej/tab-manager-redesign-bottom-toolbar to feature/ondrej/tab-manager-redesign July 22, 2025 11:38
@0nko 0nko merged commit 10b294d into feature/ondrej/tab-manager-redesign Jul 22, 2025
9 checks passed
@0nko 0nko deleted the feature/ondrej/tab-manager-redesign-buttons branch July 22, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants