Skip to content

Conversation

0nko
Copy link
Member

@0nko 0nko commented Jul 16, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1210760591708462?focus=true

Description

This PR aligns the browser omnibar toolbar buttons with the tab manager's toolbar. Also, the toolbar height is increased to 60dp across the app for consistent UX.

Steps to test this PR

Toolbar height

  • Smoke test that the toolbar height is the same in all screens

Icon alignment

  • Check that the TOP toolbar icons in the browser roughly align with the tab manager toolbar icons
  • Check that the BOTTOM toolbar icons in the browser roughly align with the tab manager toolbar icons
  • Check the above both in light and dark mode

UI changes

Bottom Top
image.png image.png

Copy link
Member Author

0nko commented Jul 16, 2025

@0nko 0nko changed the title Adjust the omnibar vertical padding paddings Tab manager update: Align toolbar icons and paddings Jul 16, 2025
@0nko 0nko marked this pull request as ready for review July 16, 2025 11:14
@0nko 0nko requested review from malmstein and nalcalag as code owners July 16, 2025 11:14
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-icon-alignment branch from 52cc305 to f3d3ad7 Compare July 18, 2025 12:13
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-bottom-menu branch from 8b1790a to c8665e8 Compare July 18, 2025 12:13
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-bottom-menu branch from c8665e8 to b5cfbe3 Compare July 21, 2025 08:37
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-icon-alignment branch from f3d3ad7 to ae25e7f Compare July 21, 2025 08:37
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-bottom-menu branch from b5cfbe3 to e1c55d0 Compare July 21, 2025 09:13
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-icon-alignment branch from ae25e7f to 169ad0a Compare July 21, 2025 09:13
Copy link
Contributor

@joshliebe joshliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-bottom-menu branch from e1c55d0 to 4b83b47 Compare July 21, 2025 10:48
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-icon-alignment branch from 169ad0a to 18580c1 Compare July 21, 2025 10:48
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-icon-alignment branch from 18580c1 to 0634a55 Compare July 22, 2025 11:57
@0nko 0nko force-pushed the feature/ondrej/tab-manager-redesign-bottom-menu branch from 4b83b47 to 3d9bbca Compare July 22, 2025 11:57
Base automatically changed from feature/ondrej/tab-manager-redesign-bottom-menu to feature/ondrej/tab-manager-redesign July 22, 2025 14:22
@0nko 0nko merged commit aef5282 into feature/ondrej/tab-manager-redesign Jul 22, 2025
10 of 12 checks passed
@0nko 0nko deleted the feature/ondrej/tab-manager-redesign-icon-alignment branch July 22, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants