Tab manager update: New layout type menu #6388
Merged
+65
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0nko
changed the title
0nko
changed the title
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-layout-type
branch
from
8b1790a to
4d57d8b
Compare
This was referenced Jul 14, 2025
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-buttons
branch
from
7da90cb to
16b112e
Compare
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-layout-type
branch
from
4d57d8b to
7e0b7f9
Compare
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-buttons
branch
from
a633599 to
15c1363
Compare
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-layout-type
branch
2 times, most recently
from
661459f to
376676d
Compare
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-buttons
branch
from
15c1363 to
6d435f4
Compare
joshliebe
reviewed
Jul 21, 2025
| pixel.fire(TAB_MANAGER_GRID_VIEW_BUTTON_CLICKED) | ||
| tabRepository.setTabLayoutType(GRID) | ||
| } | ||
| fun onListLayoutSelected() { |
joshliebe
approved these changes
Jul 21, 2025
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-layout-type
branch
from
376676d to
585955e
Compare
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-buttons
branch
from
c5d20b3 to
0c39eda
Compare
Base automatically changed from
feature/ondrej/tab-manager-redesign-buttons
to
feature/ondrej/tab-manager-redesign
July 22, 2025 11:38
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-layout-type
branch
from
585955e to
40cb628
Compare
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign
branch
from
10b294d to
76f7612
Compare
0nko
merged commit aaa81c5
into
feature/ondrej/tab-manager-redesign
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1210760591641770?focus=true
Description
This PR adds new layout type menu items that lets the users quickly see the current state and also allows them to change it.
Steps to test this PR
UI changes