Fix X_LINK_LOCAL_SHDMEM protocol mode only working once and then requiring rm /tmp/xlink.sock or reboot. #1476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the foundation for oak setup working with depthai on device.
…nd then requiring rm /tmp/xlink.sock or reboot. Incorrect X_LINK state was being reported from XLink, which caused depthai to treat the device as booted. That had the effect of not booting the FW via gate.
moratom
reviewed
Oct 1, 2025
Comment on lines
+55
to
+60
| auto gateHost = deviceInfo.name; | ||
| if (deviceInfo.protocol == X_LINK_LOCAL_SHDMEM) { | ||
| gateHost = "127.0.0.1"; | ||
| } | ||
| // Discover and connect | ||
| pimpl->cli = std::make_unique<httplib::Client>(deviceInfo.name, DEFAULT_PORT); | ||
| pimpl->cli = std::make_unique<httplib::Client>(gateHost, DEFAULT_PORT); |
There was a problem hiding this comment.
We still have to connect to gate to boot the fw - but the deviceInfo.name == /tmp/xlink.sock, so have to overwrite that. Perhaps X_LINK_LOCAL_SHDMEM should be removed from discovery altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Specification
None / not applicable
Dependencies & Potential Impact
None / not applicable
Deployment Plan
None / not applicable
Testing & Validation
Tested creating dai.Device locally multiple times in a row.
Tested as described in XLink PR as well