Skip to content

Fix X_LINK_LOCAL_SHDMEM protocol mode only working once and then requiring rm /tmp/xlink.sock or reboot. #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix X_LINK_LOCAL_SHDMEM protocol mode only working once and then requiring rm /tmp/xlink.sock or reboot. #1476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7db5d43
XLink: Added isLocalConnection to state.
zrezke Sep 30, 2025
6a56e60
fw
zrezke Sep 30, 2025
87bcb3f
X_LINK_LOCAL_SHDMEM: Fix this XLink protocol mode only working once a…
zrezke Sep 30, 2025
8263553
xlink: Fix windows compilation.
zrezke Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/Depthai/DepthaiDeviceRVC4Config.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ set(DEPTHAI_DEVICE_RVC4_MATURITY "snapshot")

# "version if applicable"
# set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+93f7b75a885aa32f44c5e9f53b74470c49d2b1af")
set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+4fec8fce82ca671df0ba4446c084e626bd53b73a")
set(DEPTHAI_DEVICE_RVC4_VERSION "0.0.1+14625de3283a5423280b17a644aab94ecdf66539")
2 changes: 1 addition & 1 deletion cmake/depthaiDependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ else()
FetchContent_Declare(
XLink
GIT_REPOSITORY https://github.com/luxonis/XLink.git
GIT_TAG 13790284ce12969c169940f88aad755bd91146db
GIT_TAG fcc46245f61d99c4dcd8c33756e0fe19ede8f230
)

FetchContent_MakeAvailable(
Expand Down
6 changes: 5 additions & 1 deletion src/device/DeviceGate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,12 @@ DeviceGate::DeviceGate(const DeviceInfo& deviceInfo) : deviceInfo(deviceInfo) {
} else {
throw std::runtime_error("Unknown platform"); // Should never happen
}
auto gateHost = deviceInfo.name;
if (deviceInfo.protocol == X_LINK_LOCAL_SHDMEM) {
gateHost = "127.0.0.1";
}
// Discover and connect
pimpl->cli = std::make_unique<httplib::Client>(deviceInfo.name, DEFAULT_PORT);
pimpl->cli = std::make_unique<httplib::Client>(gateHost, DEFAULT_PORT);
Comment on lines +55 to +60
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have to connect to gate to boot the fw - but the deviceInfo.name == /tmp/xlink.sock, so have to overwrite that. Perhaps X_LINK_LOCAL_SHDMEM should be removed from discovery altogether.

pimpl->cli->set_read_timeout(60); // 60 seconds timeout to allow for compressing the crash dumps without async
// pimpl->cli->set_connection_timeout(2);
}
Expand Down
Loading