Skip to content

[Backend Tester] Add backend filtering, improved test discovery #12624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Backend Tester] Add backend filtering, improved test discovery #12624

wants to merge 2 commits into from
+199 −39

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jul 18, 2025 •
edited
Loading

Iteratively update the backend test suite to support cleaner test flow registration, backend filtering, and a bit of misc incremental cleanup.

The test suite can now be invoked with python -m executorch.backends.test.suite.runner operators --backend xnnpack, for example.

@GregoryComer
Update
f120e70 
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Jul 18, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@GregoryComer GregoryComer requested a review from cccclai as a code owner July 18, 2025 00:27
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12624

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 12 New Failures, 72 Cancelled Jobs

As of commit ead0616 with merge base 1f885b9 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Jul 18, 2025
@GregoryComer
[Backend Tester] Add backend filtering, improved test discovery
457d54c 
ghstack-source-id: 31f569a
ghstack-comment-id: 3086061292
Pull-Request: #12624
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2025
@GregoryComer GregoryComer requested a review from digantdesai July 18, 2025 00:28
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jul 18, 2025
This was referenced Jul 18, 2025
Open
Open
Open
digantdesai
digantdesai approved these changes Jul 21, 2025
View reviewed changes
backends/test/suite/flow.py
""" A factory function that returns a Tester instance for this lowering flow. """


def create_xnnpack_flow() -> TestFlow | None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def create_xnnpack_flow() -> TestFlow | None:
@classmethod
def from_name(name: str) -> TestFlow | None:
...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly prefer the approach of having individual methods that can be explicitly called per flow, but I'll defer to your judgement if you feel strongly about it.

@GregoryComer
Update
ead0616 
[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D78708407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GregoryComer @facebook-github-bot @digantdesai