Skip to content

[Backend Tester] Add TorchAudio tests #12666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

[Backend Tester] Add TorchAudio tests #12666

wants to merge 23 commits into from

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jul 21, 2025 •
edited
Loading

Add model tests for a few torchaudio models. From testing, many models in torchaudio have data dependent behavior and require a bit of work to patch / update to export, so this list is a bit sparse for now.

@GregoryComer
Update
f120e70 
[ghstack-poisoned]
@GregoryComer
Update
0fb85e6 
[ghstack-poisoned]
@GregoryComer
Update
4d8d844 
[ghstack-poisoned]
@GregoryComer
Update
dc12b40 
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Jul 21, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@GregoryComer GregoryComer requested a review from cccclai as a code owner July 21, 2025 01:36
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12666

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Pending

As of commit 4d50265 with merge base 727937e (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Jul 21, 2025
@GregoryComer
[Backend Tester] Add TorchAudio tests
870c3ce 
ghstack-source-id: 01e7a75
ghstack-comment-id: 3095005640
Pull-Request: #12666
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2025
This was referenced Jul 21, 2025
Merged
Merged
Merged
@GregoryComer GregoryComer requested a review from digantdesai July 21, 2025 18:50
@GregoryComer
Update
ead0616 
[ghstack-poisoned]
@GregoryComer
Update
0f13676 
[ghstack-poisoned]
@GregoryComer
Update
b0b01f2 
[ghstack-poisoned]
@GregoryComer
Update
8b9c9ef 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Jul 22, 2025
@GregoryComer
[Backend Tester] Add TorchAudio tests
7b38a86 
ghstack-source-id: 8da15d2
ghstack-comment-id: 3095005640
Pull-Request: #12666
@GregoryComer
Update
06bf03a 
[ghstack-poisoned]
@GregoryComer
Update
2f8f49b 
[ghstack-poisoned]
@GregoryComer
Update
8ca7766 
[ghstack-poisoned]
@GregoryComer
Update
bffb95f 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Jul 22, 2025
@GregoryComer
[Backend Tester] Add TorchAudio tests
fdac667 
ghstack-source-id: 3f67f05
ghstack-comment-id: 3095005640
Pull-Request: #12666
@GregoryComer
Update
d21492b 
[ghstack-poisoned]
@GregoryComer
Update
e2c4ea5 
[ghstack-poisoned]
@GregoryComer
Update
8230848 
[ghstack-poisoned]
@GregoryComer
Update
2a1f564 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Jul 22, 2025
@GregoryComer
[Backend Tester] Add TorchAudio tests
0ac5fc2 
ghstack-source-id: 74754b4
ghstack-comment-id: 3095005640
Pull-Request: #12666
@GregoryComer
Update
b35e7b1 
[ghstack-poisoned]
@GregoryComer
Update
5c4c6ce 
[ghstack-poisoned]
@GregoryComer
Update
9397803 
[ghstack-poisoned]
@GregoryComer GregoryComer mentioned this pull request Jul 22, 2025
Merged
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jul 22, 2025
@GregoryComer GregoryComer mentioned this pull request Jul 22, 2025
Merged
@GregoryComer
Update
42a5de5 
[ghstack-poisoned]
@GregoryComer
Update
402d8f5 
[ghstack-poisoned]
This was referenced Jul 22, 2025
Merged
Open
Open
digantdesai
digantdesai reviewed Jul 23, 2025
View reviewed changes
backends/test/suite/runner.py
@@ -51,6 +51,8 @@ def build_result(
result=result,
error=error,
)

model.eval()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

digantdesai
digantdesai requested changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like rebase mess up>?

@GregoryComer
Update
81dfb07 
[ghstack-poisoned]
@GregoryComer
Update
4d50265 
[ghstack-poisoned]
Base automatically changed from gh/GregoryComer/79/head to main July 23, 2025 20:46
@GregoryComer
Copy link
Member Author

This was merged with #12658, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai requested changes

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GregoryComer @digantdesai