-
Notifications
You must be signed in to change notification settings - Fork 640
[Backend Tester] Clean up operator test logic #12736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12736
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 14 PendingAs of commit e2df06e with merge base 1af1d11 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you envision suite/<type>/__init__.py
per suite as a "controller" for writing tests? How do you see enforcing some suite level characteristics then? like all suits do this or support that.
It's a good point. As a follow-up, I'll refactor out the common logic from the model and operator tests. |
Unit test failures are pre-existing on main. |
Minor refactoring on the operator test logic - since we now have separate model tests, I've moved operator-test specific test helper logic into the operators directory and updated usages. I also updated discovery slightly to give nicer error messages when things don't import.
Minor refactoring on the operator test logic - since we now have separate model tests, I've moved operator-test specific test helper logic into the operators directory and updated usages. I also updated discovery slightly to give nicer error messages when things don't import.