Skip to content

[Backend Tester] Clean up operator test logic #12736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jul 24, 2025
Merged

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jul 22, 2025

Minor refactoring on the operator test logic - since we now have separate model tests, I've moved operator-test specific test helper logic into the operators directory and updated usages. I also updated discovery slightly to give nicer error messages when things don't import.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer GregoryComer requested a review from cccclai as a code owner July 22, 2025 23:47
@GregoryComer
Copy link
Member Author

GregoryComer commented Jul 22, 2025

Copy link

pytorch-bot bot commented Jul 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12736

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 14 Pending

As of commit e2df06e with merge base 1af1d11 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2025
GregoryComer added a commit that referenced this pull request Jul 22, 2025
ghstack-source-id: e6fc715
ghstack-comment-id: 3105152795
Pull-Request: #12736
@GregoryComer GregoryComer requested a review from digantdesai July 22, 2025 23:49
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you envision suite/<type>/__init__.py per suite as a "controller" for writing tests? How do you see enforcing some suite level characteristics then? like all suits do this or support that.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

do you envision suite/<type>/__init__.py per suite as a "controller" for writing tests? How do you see enforcing some suite level characteristics then? like all suits do this or support that.

It's a good point. As a follow-up, I'll refactor out the common logic from the model and operator tests.

[ghstack-poisoned]
[ghstack-poisoned]
Base automatically changed from gh/GregoryComer/83/head to main July 23, 2025 23:28
@GregoryComer GregoryComer requested a review from shoumikhin as a code owner July 23, 2025 23:28
[ghstack-poisoned]
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jul 23, 2025
@GregoryComer
Copy link
Member Author

Unit test failures are pre-existing on main.

@GregoryComer GregoryComer merged commit 6cfb464 into main Jul 24, 2025
96 of 100 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/85/head branch July 24, 2025 00:02
Conarnar pushed a commit to Conarnar/executorch that referenced this pull request Jul 25, 2025
Minor refactoring on the operator test logic - since we now have
separate model tests, I've moved operator-test specific test helper
logic into the operators directory and updated usages. I also updated
discovery slightly to give nicer error messages when things don't
import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants