Skip to content

[Backend Tester] Add model test skeleton and torchvision tests #12658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 23, 2025
Merged

[Backend Tester] Add model test skeleton and torchvision tests #12658

merged 16 commits into from
Jul 23, 2025

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jul 19, 2025 •
edited
Loading

Add the structure for model tests in the backend test suite and populate torchvision models.

@GregoryComer
Update
f120e70 
[ghstack-poisoned]
@GregoryComer
Update
0fb85e6 
[ghstack-poisoned]
@GregoryComer
Update
4d8d844 
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Jul 19, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@GregoryComer GregoryComer requested a review from cccclai as a code owner July 19, 2025 02:52
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12658

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 16 Pending

As of commit 81dfb07 with merge base 727937e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Jul 19, 2025
@GregoryComer
[Backend Tester] Add model test skeleton and torchvision tests
d780a06 
ghstack-source-id: ac0e6f7
ghstack-comment-id: 3091440611
Pull-Request: #12658
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 19, 2025
This was referenced Jul 19, 2025
Merged
Merged
Closed
@GregoryComer GregoryComer requested a review from digantdesai July 21, 2025 18:50
@GregoryComer
Update
ead0616 
[ghstack-poisoned]
@GregoryComer
Update
0f13676 
[ghstack-poisoned]
@GregoryComer
Update
b0b01f2 
[ghstack-poisoned]
GregoryComer added a commit that referenced this pull request Jul 22, 2025
@GregoryComer
[Backend Tester] Add model test skeleton and torchvision tests
9a0c0bd 
ghstack-source-id: c7bdc4d
ghstack-comment-id: 3091440611
Pull-Request: #12658
@GregoryComer
Update
06bf03a 
[ghstack-poisoned]
@GregoryComer
Update
2f8f49b 
[ghstack-poisoned]
@GregoryComer
Update
8ca7766 
[ghstack-poisoned]
@GregoryComer
Update
d21492b 
[ghstack-poisoned]
@GregoryComer
Update
e2c4ea5 
[ghstack-poisoned]
@GregoryComer
Update
8230848 
[ghstack-poisoned]
@GregoryComer
Update
b35e7b1 
[ghstack-poisoned]
@GregoryComer
Update
5c4c6ce 
[ghstack-poisoned]
@GregoryComer GregoryComer mentioned this pull request Jul 22, 2025
Merged
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jul 22, 2025
@GregoryComer GregoryComer mentioned this pull request Jul 22, 2025
Merged
Base automatically changed from gh/GregoryComer/78/head to main July 22, 2025 23:47
@GregoryComer
Update
42a5de5 
[ghstack-poisoned]
@GregoryComer GregoryComer mentioned this pull request Jul 22, 2025
Open
This was referenced Jul 23, 2025
Open
Open
digantdesai
digantdesai approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we selecting models from torchaudio and torchvision?

If we are indeed selecting let's make a comment about how and why.

@GregoryComer
Update
81dfb07 
[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

How are we selecting models from torchaudio and torchvision?

If we are indeed selecting let's make a comment about how and why.

Added a comment to torchvision and torchaudio tests.

@GregoryComer GregoryComer merged commit 503db13 into main Jul 23, 2025
99 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/79/head branch July 23, 2025 20:46
@GregoryComer GregoryComer mentioned this pull request Jul 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GregoryComer @digantdesai