rocrtst: Support GPU targets defined in theRock#3400
Merged
JeniferC99 merged 1 commit intodevelopfrom Feb 24, 2026
Merged
Conversation
cfreeamd
approved these changes
Feb 20, 2026
projects/rocr-runtime/rocrtst/suites/test_common/CMakeLists.txt
Outdated
Show resolved
Hide resolved
projects/rocr-runtime/rocrtst/suites/test_common/CMakeLists.txt
Outdated
Show resolved
Hide resolved
shwetagkhatri
requested changes
Feb 20, 2026
amd-alysaliu
force-pushed
the
users/alysaliu/AILIROCR-35
branch
2 times, most recently
from
404f3d7 to
35a51f9
Compare
Use GPU_TARGETS/AMDGPU_TARGETS defined in TheRock when TARGET_DEVICES not set. Signed-off-by: Alysa Liu <Alysa.Liu@amd.com>
amd-alysaliu
force-pushed
the
users/alysaliu/AILIROCR-35
branch
from
35a51f9 to
bad086b
Compare
Collaborator
|
passing ocl and hip: http://rocm-ci.amd.com/job/rocm-tests/40967/ |
amd-josnarlo
pushed a commit
that referenced
this pull request
Feb 25, 2026
Use GPU_TARGETS/AMDGPU_TARGETS defined in TheRock when TARGET_DEVICES not set. Signed-off-by: Alysa Liu <Alysa.Liu@amd.com>
radhaksri
pushed a commit
that referenced
this pull request
Feb 26, 2026
Use GPU_TARGETS/AMDGPU_TARGETS defined in TheRock when TARGET_DEVICES not set. Signed-off-by: Alysa Liu <Alysa.Liu@amd.com>
Collaborator
|
rocr test failures in ROCm/TheRock#3602 where The test script in This gap would not have been caught through rocm-systems pull requests until #3182 lands. @rahulc-gh The changes in this PR #3400 need to land on TheRock through a submodule update at the same time as the test scripts for ROCR are updated to account for the |
This was referenced Feb 27, 2026
1 task
jharryma
added a commit
to ROCm/TheRock
that referenced
this pull request
Mar 3, 2026
## Motivation Resolves: #3666 rocm-systems submodule bump #3668 introduced an issue on TheRock CI with the rocrtst generic tarball where only the last gfx arch built rocrtst binaries are the ones uploaded to the generic tarball. (e.g. if gfx120X tarball is built last, it will be the only one included in the generic tarball, causing gfx94X tests to fail) Introduced in this rocm-systems PR: ROCm/rocm-systems#3400 This issue is similar to aqlprofile and hip-tests: #3679. We'll need to set it back to target-neutral for multi-arch CI ## Technical Details Setting rocrtst to target-specific. ## Test Plan Test rocrtst for multiple archs ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use GPU_TARGETS/AMDGPU_TARGETS defined in TheRock when TARGET_DEVICES not set.
Related to issue #2262