Skip to content

Conversation

@RachelCoackley
Copy link
Contributor

Setting default values for trk.bestplane and shw.producer. When the sbnd CI was being ran differences in the caf stage were appearing due to these variables not being initialised with a default value. Warnings looked like:

664:   rec.slc[0].reco.pfp[0].shw.producer differs: 632172960 vs 622129504
665:   rec.slc[0].reco.pfp[0].trk.bestplane differs: 786776544 vs -1706641423

This change sets default values for these variables, removing this warning from the CI.

@kjplows
Copy link
Contributor

kjplows commented Mar 26, 2025

Hi @PetrilloAtWork and @JosiePaton , could either of you please take a look at this PR? Many thanks!

@kjplows
Copy link
Contributor

kjplows commented Mar 27, 2025

trigger build

@kjplows kjplows moved this from Open pull requests to Testing in SBN software development Mar 27, 2025
@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Mar 27, 2025
@FNALbuild
Copy link

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows merged commit 6d64b4a into develop Mar 27, 2025
5 of 7 checks passed
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Mar 27, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Mar 27, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Apr 10, 2025
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in PR archaeology Jan 16, 2026
@kjplows kjplows added this to the v10_04_07 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done
Status: 2025 PRs

Development

Successfully merging this pull request may close these issues.

5 participants