Add num_entities() to World
#19780
Merged
Add num_entities() to World
#19780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trashtalk217
added
D-Trivial
alice-i-cecile
approved these changes
Jun 22, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
Co-authored-by: Alice Cecile <[email protected]>
hukasu
approved these changes
Jun 22, 2025
|
@alice-i-cecile IMO we arguably should prefer naming things There's only a handful for functions starting with 
But more end with 
|
|
Yeah, I'm down with that. If you submit a rename PR I'll approve it :) |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
As discussed in #19780 (comment).
Trashtalk217
added a commit
to Trashtalk217/bevy
that referenced
this pull request
Jul 10, 2025
There is a lot of `world.entities().len()`, especially in tests. In tests, usually, the assumption is made that empty worlds do not contain any entities. This is about to change (bevyengine#19711), and as such all of these tests are failing for that PR. `num_entities` is a convenience method that returns the number of entities inside a world. It can later be adapted to exclude 'unexpected' entities, associated with internal data structures such as Resources, Queries, Systems. In general I argue for a separation of concepts where `World` ignores internal entities in methods such as `iter_entities()` and `clear_entities()`, that discussion is, however, separate from this PR. I replaced most occurrences of `world.entities().len()` with `world.num_entities()` and the tests passed. --------- Co-authored-by: Alice Cecile <[email protected]>
Trashtalk217
pushed a commit
to Trashtalk217/bevy
that referenced
this pull request
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
There is a lot of
world.entities().len(), especially in tests. In tests, usually, the assumption is made that empty worlds do not contain any entities. This is about to change (#19711), and as such all of these tests are failing for that PR.Solution
num_entitiesis a convenience method that returns the number of entities inside a world. It can later be adapted to exclude 'unexpected' entities, associated with internal data structures such as Resources, Queries, Systems. In general I argue for a separation of concepts whereWorldignores internal entities in methods such asiter_entities()andclear_entities(), that discussion is, however, separate from this PR.Testing
I replaced most occurrences of
world.entities().len()withworld.num_entities()and the tests passed.