- 
                Notifications
    You must be signed in to change notification settings 
- Fork 11
Fix singleton in StatisticsBackendData [15841] #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3d3735c    to
    b1744c5      
    Compare
  
    b1744c5    to
    5b7afb5      
    Compare
  
    e1a24bb    to
    98e7802      
    Compare
  
    98e7802    to
    f5a4a16      
    Compare
  
    f5a4a16    to
    4198115      
    Compare
  
    4198115    to
    56aa95a      
    Compare
  
    8eee71f    to
    a07fbcf      
    Compare
  
    863cc1a    to
    d5b4962      
    Compare
  
    d5b4962    to
    bb399c1      
    Compare
  
    bb399c1    to
    c0b6a68      
    Compare
  
    c0b6a68    to
    6bc3953      
    Compare
  
    Signed-off-by: jparisu <[email protected]>
…and with itself in destruction) Signed-off-by: jparisu <[email protected]>
… destruction Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
6bc3953    to
    aacf5cc      
    Compare
  
    | Codecov ReportBase: 57.82% // Head: 58.08% // Increases project coverage by  
 Additional details and impacted files@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   57.82%   58.08%   +0.26%     
==========================================
  Files          31       32       +1     
  Lines        4320     4345      +25     
  Branches     2310     2318       +8     
==========================================
+ Hits         2498     2524      +26     
+ Misses         60       59       -1     
  Partials     1762     1762              
 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. | 
        
          
                test/unittest/StatisticsBackend/InitMonitorFactoryFailsTests.cpp
              
                Outdated
          
            Show resolved
            Hide resolved
        
      Signed-off-by: jparisu <[email protected]>
8796a1e    to
    412854d      
    Compare
  
    Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: jparisu <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with correct CI
Fix a Memory Leak problem related with Singleton
StatisticsBackendDataThis PR fixes some ASAN problems related with
StatisticsBackendData, but not all memory errors. Thus the asan job is expected to keep failing.Merge after: