Skip to content

[23568] Set different content filter signatures for each requester #5972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

[23568] Set different content filter signatures for each requester #5972

merged 2 commits into from
Aug 26, 2025

Conversation

@Carlosespicur
Copy link
Contributor

@Carlosespicur Carlosespicur commented Aug 1, 2025 •
edited by MiguelCompany
Loading

Description

This PR fixes an error detected when on a RPC scenario with two clients using a single server with thread pool, in which one the clients does not receive the replies sent by the server. As each requester uses a filter with the same signature (i:e: same expression and parameters), replies sent to the client 2 (the one that does not receive the replies) are discarded at the Requester's reader size, because the evaluation for client 1 was false. The problem is resolved by setting different filter signatures for each requester.

@Mergifyio backport 3.3.x 3.2.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@github-actions github-actions bot added the ci-pending PR which CI is running label Aug 1, 2025
@Carlosespicur Carlosespicur added this to the v3.4.0 milestone Aug 1, 2025
@Carlosespicur
Refs #23568: Add test
0b8d437 
Signed-off-by: Carlosespicur <[email protected]>
@Carlosespicur Carlosespicur requested review from MiguelCompany and removed request for MiguelCompany August 4, 2025 06:43
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany August 25, 2025 06:37
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 0b8d437.

❌ Failed Jobs

Pipeline Job Health on base branch Retries 🔍 CI Insights 📄 Logs
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v143 Unknown 1 View View

@MiguelCompany MiguelCompany merged commit 5e01f49 into master Aug 26, 2025
60 of 69 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/23568 branch August 26, 2025 07:53
@MiguelCompany
Copy link
Member

MiguelCompany commented Aug 26, 2025

@Mergifyio backport 3.3.x 3.2.x

@mergify
Copy link
Contributor

mergify bot commented Aug 26, 2025 •
edited
Loading

backport 3.3.x 3.2.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 26, 2025
@Carlosespicur @mergify
Set different content filter signatures for each requester (#5972)
a85e388 
* Refs #23568: Set different content filter signatures for each requester

Signed-off-by: Carlosespicur <[email protected]>

* Refs #23568: Add test

Signed-off-by: Carlosespicur <[email protected]>

---------

Signed-off-by: Carlosespicur <[email protected]>
(cherry picked from commit 5e01f49)
mergify bot pushed a commit that referenced this pull request Aug 26, 2025
@Carlosespicur @mergify
Set different content filter signatures for each requester (#5972)
be78cdc 
* Refs #23568: Set different content filter signatures for each requester

Signed-off-by: Carlosespicur <[email protected]>

* Refs #23568: Add test

Signed-off-by: Carlosespicur <[email protected]>

---------

Signed-off-by: Carlosespicur <[email protected]>
(cherry picked from commit 5e01f49)

# Conflicts:
#	src/cpp/fastdds/rpc/RequesterImpl.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.hpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldRequester.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldRequester.hpp
#	test/blackbox/common/DDSBlackboxTestsRPC.cpp
This was referenced Aug 26, 2025
Merged
Merged
MiguelCompany pushed a commit that referenced this pull request Sep 17, 2025
@mergify @Carlosespicur
Set different content filter signatures for each requester (#5972) (#…
4441438 
…5984)

* Refs #23568: Set different content filter signatures for each requester



* Refs #23568: Add test



---------


(cherry picked from commit 5e01f49)

Signed-off-by: Carlosespicur <[email protected]>
Co-authored-by: Carlos Espinoza Curto <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Oct 14, 2025
@Carlosespicur @MiguelCompany
Set different content filter signatures for each requester (#5972)
da809fd 
* Refs #23568: Set different content filter signatures for each requester

Signed-off-by: Carlosespicur <[email protected]>

* Refs #23568: Add test

Signed-off-by: Carlosespicur <[email protected]>

---------

Signed-off-by: Carlosespicur <[email protected]>
(cherry picked from commit 5e01f49)

# Conflicts:
#	src/cpp/fastdds/rpc/RequesterImpl.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.hpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldRequester.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldRequester.hpp
#	test/blackbox/common/DDSBlackboxTestsRPC.cpp
MiguelCompany pushed a commit that referenced this pull request Oct 14, 2025
@Carlosespicur @MiguelCompany
Set different content filter signatures for each requester (#5972)
0e78d6b 
* Refs #23568: Set different content filter signatures for each requester

Signed-off-by: Carlosespicur <[email protected]>

* Refs #23568: Add test

Signed-off-by: Carlosespicur <[email protected]>

---------

Signed-off-by: Carlosespicur <[email protected]>
(cherry picked from commit 5e01f49)

# Conflicts:
#	src/cpp/fastdds/rpc/RequesterImpl.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.hpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldRequester.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldRequester.hpp
#	test/blackbox/common/DDSBlackboxTestsRPC.cpp
MiguelCompany added a commit that referenced this pull request Oct 15, 2025
@mergify @Carlosespicur @MiguelCompany
Set different content filter signatures for each requester (#5972) (#…
2c782f3 
…5985)

* Set different content filter signatures for each requester (#5972)

* Refs #23568: Set different content filter signatures for each requester

Signed-off-by: Carlosespicur <[email protected]>

* Refs #23568: Add test

Signed-off-by: Carlosespicur <[email protected]>

---------

Signed-off-by: Carlosespicur <[email protected]>
(cherry picked from commit 5e01f49)

# Conflicts:
#	src/cpp/fastdds/rpc/RequesterImpl.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.hpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldRequester.cpp
#	test/blackbox/api/dds-pim/ReqRepHelloWorldRequester.hpp
#	test/blackbox/common/DDSBlackboxTestsRPC.cpp

* Fix conflicts.

Signed-off-by: Miguel Company <[email protected]>

* Fix build

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Carlos Espinoza Curto <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v3.4.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

3 participants

@Carlosespicur @MiguelCompany