-
Notifications
You must be signed in to change notification settings - Fork 868
[23568] Set different content filter signatures for each requester (backport #5972) #5985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of 5e01f49 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
11 tasks
@MiguelCompany could you please solve the conflicts here? |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
fdd16b7
to
66ea3d2
Compare
* Refs #23568: Set different content filter signatures for each requester Signed-off-by: Carlosespicur <[email protected]> * Refs #23568: Add test Signed-off-by: Carlosespicur <[email protected]> --------- Signed-off-by: Carlosespicur <[email protected]> (cherry picked from commit 5e01f49) # Conflicts: # src/cpp/fastdds/rpc/RequesterImpl.cpp # test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.cpp # test/blackbox/api/dds-pim/ReqRepHelloWorldReplier.hpp # test/blackbox/api/dds-pim/ReqRepHelloWorldRequester.cpp # test/blackbox/api/dds-pim/ReqRepHelloWorldRequester.hpp # test/blackbox/common/DDSBlackboxTestsRPC.cpp
Signed-off-by: Miguel Company <[email protected]>
66ea3d2
to
9b7dffa
Compare
Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an error detected when on a RPC scenario with two clients using a single server with thread pool, in which one the clients does not receive the replies sent by the server. As each requester uses a filter with the same signature (i:e: same expression and parameters), replies sent to the client 2 (the one that does not receive the replies) are discarded at the Requester's reader size, because the evaluation for client 1 was false. The problem is resolved by setting different filter signatures for each requester.
@Mergifyio backport 3.3.x 3.2.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.md
file (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5972 done by [Mergify](https://mergify.com).