Added a least squares solver in pd_solve() #1542
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a least squares solver to the pd_solve function to prevent errors when np.linalg.solve(a, b) fails, without having to directly modify the ridge regression regularization coefficient.
Fixes #1524
Type of change
Branching
Has your PR been tested?
If you're fixing a bug or introducing a new feature it is recommended you run the tests by typing
caimanmanager testand
caimanmanager demotestprior to submitting your pull request.
Please describe any additional tests that you ran to verify your changes. If they are fast you can also
include them in the folder 'caiman/tests/
and name themtest_***.py` so they can be included in our lists of tests.