Skip to content

Conversation

@zyyk78
Copy link
Contributor

@zyyk78 zyyk78 commented Nov 10, 2025

Description

Added a least squares solver to the pd_solve function to prevent errors when np.linalg.solve(a, b) fails, without having to directly modify the ridge regression regularization coefficient.

Fixes #1524

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Branching

  • All PRs should be made against the dev branch. The main branch is not often merged back to dev.
  • If you want to get your PR out to the world faster (urgent bugfix), poke pgunn to cut a release; this will get it onto github and into conda faster

Has your PR been tested?

If you're fixing a bug or introducing a new feature it is recommended you run the tests by typing

caimanmanager test

and

caimanmanager demotest

prior to submitting your pull request.

Please describe any additional tests that you ran to verify your changes. If they are fast you can also
include them in the folder 'caiman/tests/and name themtest_***.py` so they can be included in our lists of tests.

pgunn and others added 2 commits July 17, 2025 14:01
Added error handling for linear solve failure, using least squares as fallback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants