Skip to content

Added a least squares solver in pd_solve() #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Added a least squares solver in pd_solve() #1542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd18f10
Merge pull request #1514 from flatironinstitute/dev
pgunn Jul 17, 2025
edf95a0
Improve linear solve with fallback to least squares
zyyk78 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion caiman/utils/stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,4 +329,10 @@ def pd_solve(a, b):
if info == 0:
return dpotrs(L, b)[0]
else:
return np.linalg.solve(a, b)
try:
pdsv = np.linalg.solve(a, b)
except LinAlgError :
logger = logging.getLogger("caiman")
logger.warning("Unable to solve directly, using least squares instead.")
pdsv = np.linalg.lstsq(a, b, rcond=None)[0]
return pdsv
Loading