Updates on midi and build system #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 14, 2025
Closed
Reimplement Midi adapters using Android Midi API, reusing Peter's (from/to)WireConverters coming from: https://github.com/nettoyeurny/btmidi/blob/master/AndroidMidi/src/com/noisepages/nettoyeur/midi/
AGP 8.11.0 gradle 8.13 buildToolsVersion 35.0.0 ndk 27.2.12479018
this allows to make apps independent from PdCore sources, so they can declare pd-core dependency like a maven one.
…ite' style dependency
|
Fixes #157 ? |
…ign to 16KB pagesize, as required by google
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
com.noisepages.nettoyeur:midi) and other fixesThe latter allows to fix the CI build, as well as long standing issues about adding native code externals to Pd in Android apps.
Here is a quick description of the changes:
This has the benefit that now, pd-core dependency is declared by the apps the same way as if they were standalone; so they can safely be taken as examples.
Note: 2 small issues remain:
prefab, not only the needed.hfiles. This could be fixed with copying the only needed files to a temporaryinclude/dir before building.Anyway this issue doesn't harm much, because final apps don't include the prefab dir.
1.3.0for now, to be discussed) is present at 2 distinct places:build.gradleandPdCore/build.gradle, and both need to be kept in sync.I couldn't find a way to merge them both.
Fixes #127.
Fixes #157.
Closes #75.