Fix slim Windows release packaging and update CI pnpm setup for Node 24#377
Fix slim Windows release packaging and update CI pnpm setup for Node 24#377
Conversation
Agent-Logs-Url: https://github.com/mcthesw/game-save-manager/sessions/89ac0ce6-0920-4ef3-862d-aadbe78e47f9 Co-authored-by: mcthesw <61224072+mcthesw@users.noreply.github.com>
|
@copilot 另外也修复一下Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: pnpm/action-setup@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/ |
Agent-Logs-Url: https://github.com/mcthesw/game-save-manager/sessions/447dd328-2905-4a2e-a66f-a1e1e3aeebb7 Co-authored-by: mcthesw <61224072+mcthesw@users.noreply.github.com>
已处理,相关 workflow 里的 |
There was a problem hiding this comment.
Pull request overview
Fixes the slim Windows release packaging path by calling the Tauri CLI with a correctly-scoped --config argument and by ensuring portable packaging failures propagate as non-zero exit codes in CI. Also updates workflows to use a Node 24-compatible pnpm/action-setup version.
Changes:
- Add a
runPortableCliwrapper soscripts/portable.mjsexits non-zero on packaging errors, and add targeted unit tests. - Update GitHub Actions workflows to use
pnpm/action-setup@v5and normalize some YAML quoting. - Split slim Windows release into dedicated “build slim app” and “portable packaging” steps with the correct Tauri CLI invocation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/portable.mjs | Adds runPortableCli wrapper and uses it in CLI entrypoint to propagate failures via exit code. |
| scripts/portable.test.mjs | Adds tests for the new CLI wrapper success/failure behavior. |
| .github/workflows/copilot-setup-steps.yml | Updates pnpm setup action to @v5 and minor YAML formatting. |
| .github/workflows/code-test.yml | Updates pnpm setup action to @v5 and minor YAML formatting. |
| .github/workflows/code-style.yml | Updates pnpm setup action to @v5 and minor YAML formatting. |
| .github/workflows/build-gui.yml | Fixes slim Windows build command (correct --config + Cargo arg forwarding) and separates slim build vs portable packaging steps; updates pnpm setup action to @v5. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Setup Node.js | ||
| uses: actions/setup-node@v5 | ||
| with: | ||
| node-version: lts/* | ||
| cache: 'pnpm' | ||
| cache: "pnpm" | ||
|
|
There was a problem hiding this comment.
The new scripts/portable.test.mjs coverage for runPortableCli does not appear to run anywhere in CI (no workflow or package script invokes node --test). Consider adding a step in this workflow (after pnpm install) to execute the Node test suite so regressions in the portable CLI wrapper are caught automatically.
|
@copilot 当前问题: 其次,应该给手动触发workflow加一个checkbox input选项,勾选是否输出windows便携版(在自动构建中始终构建) |
Agent-Logs-Url: https://github.com/mcthesw/game-save-manager/sessions/d9c83df6-efbe-4bfa-9c2c-ce4f996c0ec8 Co-authored-by: mcthesw <61224072+mcthesw@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mcthesw/game-save-manager/sessions/13cfa2a8-198a-4aee-b7e1-39383861a1a9 Co-authored-by: mcthesw <61224072+mcthesw@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mcthesw/game-save-manager/sessions/a9afa6e5-eb95-4f91-ad71-efa7a262c6ae Co-authored-by: mcthesw <61224072+mcthesw@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mcthesw/game-save-manager/sessions/f38cc6b2-0b5c-424e-8412-9feadc398715 Co-authored-by: mcthesw <61224072+mcthesw@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mcthesw/game-save-manager/sessions/3d519e5a-07e5-4d8e-9d92-6a28d8e4cb77 Co-authored-by: mcthesw <61224072+mcthesw@users.noreply.github.com>
…ature Agent-Logs-Url: https://github.com/mcthesw/game-save-manager/sessions/ea5d28ab-a616-468f-82c3-a6b2cda880da Co-authored-by: mcthesw <61224072+mcthesw@users.noreply.github.com>
rgsm-coreworkspace dependency haddefault-features = true(implicit), so--no-default-featuresonly disabledrgsmdefaults but NOTrgsm-core/bundled-manifestCargo.tomlto setdefault-features = falseforrgsm-corerust-embed/bundled-manifest--no-default-features) excludesrust-embedentirelyrgsm,rgsm-cli,rgsm-ffi)