Skip to content

Fix slim Windows release packaging and update CI pnpm setup for Node 24 #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcthesw merged 16 commits into from
Apr 15, 2026
Merged

Fix slim Windows release packaging and update CI pnpm setup for Node 24 #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3b508f8
Initial plan
Copilot Apr 13, 2026
90dc670
fix(ci): surface slim portable build failures
Copilot Apr 13, 2026
895720a
ci: upgrade pnpm action to node24-compatible version
Copilot Apr 13, 2026
5575622
fix(ci): skip portable upload outside releases
Copilot Apr 15, 2026
c4698f9
ci: add manual portable build toggle
Copilot Apr 15, 2026
4489a86
refactor(ci): simplify build and release workflows
Copilot Apr 15, 2026
f41a087
fix(ci): tighten publish workflow permissions
Copilot Apr 15, 2026
a059bdc
fix(ci): make platform matrix selection explicit
Copilot Apr 15, 2026
d9eed3e
fix(ci): avoid artifact name collisions
Copilot Apr 15, 2026
53fc568
chore(ci): align portable build steps
Copilot Apr 15, 2026
4661c23
fix(ci): gate portable jobs on matrix validation
Copilot Apr 15, 2026
6991a67
refactor(ci): simplify to 4 independent build jobs
Copilot Apr 15, 2026
d33d283
fix(ci): fix win input description to Build Windows
Copilot Apr 15, 2026
3b222c7
fix(ci): correct build gui artifact uploads
Copilot Apr 15, 2026
a1c28d6
fix(ci): upload build artifacts as separate files
Copilot Apr 15, 2026
a39c363
fix(build): :bug: make portable slim actually disable bundled-manifes…
Copilot Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
236 changes: 154 additions & 82 deletions .github/workflows/build-gui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,91 +1,170 @@
name: Build GUI

on:
release:
types: [published]
workflow_dispatch:
inputs:
platform:
description: 'Target platform'
required: true
type: choice
options:
- all
- windows-latest
- ubuntu-24.04
- macos-latest
default: 'ubuntu-24.04'
win:
description: "Build Windows"
type: boolean
default: false
linux:
description: "Build Linux"
type: boolean
default: false
macos:
description: "Build macOS"
type: boolean
default: false
windows_portable_slim:
description: "Build Windows portable slim"
type: boolean
default: false
workflow_call:
inputs:
win:
type: boolean
default: false
linux:
type: boolean
default: false
macos:
type: boolean
default: false
windows_portable_slim:
type: boolean
default: false
release_id:
type: string
default: ""
release_tag:
type: string
default: ""

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
prepare-matrix:
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
build-win:
if: inputs.win
runs-on: windows-latest
permissions:
contents: write
steps:
- id: set-matrix
run: |
if [ "${{ github.event_name }}" = "workflow_dispatch" ] && [ "${{ inputs.platform }}" != "all" ]; then
PLATFORM="${{ inputs.platform }}"
if [ "$PLATFORM" = "macos-latest" ]; then
ARGS="--target aarch64-apple-darwin"
else
ARGS=""
fi
echo "matrix={\"include\":[{\"platform\":\"$PLATFORM\",\"args\":\"$ARGS\"}]}" >> $GITHUB_OUTPUT
else
echo 'matrix={"include":[{"platform":"macos-latest","args":"--target aarch64-apple-darwin"},{"platform":"ubuntu-24.04","args":""},{"platform":"windows-latest","args":""}]}' >> $GITHUB_OUTPUT
fi
- uses: actions/checkout@v5
- uses: actions/setup-node@v5
with:
node-version: lts/*
- uses: pnpm/action-setup@v5
with:
version: latest
- uses: dtolnay/rust-toolchain@stable
- run: pnpm install
- uses: Swatinem/rust-cache@v2
- uses: tauri-apps/tauri-action@v0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tauriScript: pnpm tauri
projectPath: apps/rgsm-gui
releaseId: ${{ github.event_name == 'workflow_call' && inputs.release_id || '' }}
- uses: actions/upload-artifact@v7
with:
path: target/release/bundle/nsis/RGSM_*_x64-setup.exe
if-no-files-found: error
archive: false
- uses: actions/upload-artifact@v7
with:
path: target/release/bundle/msi/RGSM_*_x64_en-US.msi
if-no-files-found: error
archive: false

build-gui:
needs: prepare-matrix
build-linux:
if: inputs.linux
runs-on: ubuntu-24.04
permissions:
contents: write
strategy:
fail-fast: false
matrix: ${{ fromJSON(needs.prepare-matrix.outputs.matrix) }}
runs-on: ${{ matrix.platform }}
steps:
- uses: actions/checkout@v5
- name: Setup Node.js
uses: actions/setup-node@v5
- uses: actions/setup-node@v5
with:
node-version: lts/*
- name: Setup pnpm
uses: pnpm/action-setup@v4
- uses: pnpm/action-setup@v5
with:
version: latest
- name: Install Rust stable
uses: dtolnay/rust-toolchain@stable
- name: Install system dependencies (Ubuntu)
if: matrix.platform == 'ubuntu-24.04'
run: |
- uses: dtolnay/rust-toolchain@stable
- run: |
sudo apt-get update
sudo apt-get install -y libwebkit2gtk-4.1-dev build-essential curl wget file libxdo-dev libssl-dev libayatana-appindicator3-dev librsvg2-dev pkg-config libasound2-dev
- name: Install frontend dependencies
run: pnpm install
- name: Restore Rust cache
uses: Swatinem/rust-cache@v2
- name: Build with Tauri
uses: tauri-apps/tauri-action@v0
- run: pnpm install
- uses: Swatinem/rust-cache@v2
- uses: tauri-apps/tauri-action@v0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tauriScript: pnpm tauri
projectPath: apps/rgsm-gui
releaseId: ${{ github.event_name == 'release' && github.event.release.id || '' }}
args: ${{ matrix.args }}
releaseId: ${{ github.event_name == 'workflow_call' && inputs.release_id || '' }}
- uses: actions/upload-artifact@v7
with:
path: target/release/bundle/deb/RGSM_*.deb
if-no-files-found: error
archive: false
- uses: actions/upload-artifact@v7
with:
path: target/release/bundle/rpm/RGSM-*.rpm
if-no-files-found: error
archive: false
- uses: actions/upload-artifact@v7
with:
path: target/release/bundle/appimage/RGSM_*.AppImage
if-no-files-found: error
archive: false

build-macos:
if: inputs.macos
runs-on: macos-latest
permissions:
contents: write
steps:
- uses: actions/checkout@v5
- uses: actions/setup-node@v5
with:
node-version: lts/*
- uses: pnpm/action-setup@v5
with:
version: latest
- uses: dtolnay/rust-toolchain@stable
with:
targets: aarch64-apple-darwin
- run: pnpm install
- uses: Swatinem/rust-cache@v2
- uses: tauri-apps/tauri-action@v0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tauriScript: pnpm tauri
projectPath: apps/rgsm-gui
releaseId: ${{ github.event_name == 'workflow_call' && inputs.release_id || '' }}
args: --target aarch64-apple-darwin
- uses: actions/upload-artifact@v7
with:
path: target/aarch64-apple-darwin/release/bundle/dmg/RGSM_*.dmg
if-no-files-found: error
archive: false
- uses: actions/upload-artifact@v7
with:
path: target/aarch64-apple-darwin/release/bundle/macos/*.app.tar.gz
if-no-files-found: error
archive: false
- name: Fix macOS updater artifact name
if: matrix.platform == 'macos-latest' && github.event_name == 'release'
if: github.event_name == 'workflow_call' && inputs.release_id != ''
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
TAG="${{ github.event.release.tag_name }}"
TAG="${{ inputs.release_tag }}"
VERSION="${TAG#v}"
RELEASE_ID="${{ github.event.release.id }}"
RELEASE_ID="${{ inputs.release_id }}"
gh api "repos/${{ github.repository }}/releases/${RELEASE_ID}/assets" \
--jq '.[] | select(.name | test("\\.app\\.tar\\.gz")) | "\(.id)\t\(.name)"' |
while IFS=$'\t' read -r ASSET_ID OLD_NAME; do
Expand All @@ -96,44 +175,37 @@ jobs:
echo "Renamed: ${OLD_NAME} -> ${NEW_NAME}"
fi
done
- name: Build portable (Windows only)
if: matrix.platform == 'windows-latest' && github.event_name == 'release'
run: |
pnpm build
pnpm portable
env:
RELEASE_ID: ${{ github.event.release.id }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VITE_WIN_PORTABLE: 1

build-slim-portable:
if: github.event_name == 'release' || (github.event_name == 'workflow_dispatch' && (inputs.platform == 'all' || inputs.platform == 'windows-latest'))
build-windows-portable-slim:
if: inputs.windows_portable_slim
runs-on: windows-latest
permissions:
contents: write
steps:
- uses: actions/checkout@v5
- name: Setup Node.js
uses: actions/setup-node@v5
- uses: actions/setup-node@v5
with:
node-version: lts/*
- name: Setup pnpm
uses: pnpm/action-setup@v4
- uses: pnpm/action-setup@v5
with:
version: latest
- name: Install Rust stable
uses: dtolnay/rust-toolchain@stable
- name: Install frontend dependencies
run: pnpm install
- name: Restore Rust cache
uses: Swatinem/rust-cache@v2
- name: Build slim portable
run: |
pnpm build -- --config src-tauri/tauri.slim.conf.json --no-default-features
pnpm portable
- uses: dtolnay/rust-toolchain@stable
- run: pnpm install
- uses: Swatinem/rust-cache@v2
- name: Build slim app
run: pnpm tauri build --config src-tauri/tauri.slim.conf.json -- --no-default-features
working-directory: apps/rgsm-gui
env:
RELEASE_ID: ${{ github.event.release.id }}
VITE_WIN_PORTABLE: 1
- name: Build slim portable
run: pnpm portable
env:
RELEASE_ID: ${{ github.event_name == 'workflow_call' && inputs.release_id || '' }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
RGSM_BUILD_VARIANT: slim
VITE_WIN_PORTABLE: 1
- uses: actions/upload-artifact@v7
with:
path: RGSM_*_x64-portable-slim.zip
if-no-files-found: error
archive: false
8 changes: 4 additions & 4 deletions .github/workflows/code-style.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Code Style

on:
pull_request:
branches: ['dev']
branches: ["dev"]
push:
branches: ['dev']
branches: ["dev"]

concurrency:
group: code-style-${{ github.event.pull_request.number || github.ref }}
Expand Down Expand Up @@ -34,15 +34,15 @@ jobs:
pkg-config

- name: Setup pnpm
uses: pnpm/action-setup@v4
uses: pnpm/action-setup@v5
with:
version: latest

- name: Setup Node.js
uses: actions/setup-node@v5
with:
node-version: lts/*
cache: 'pnpm'
cache: "pnpm"

- name: Install frontend dependencies
run: pnpm install --frozen-lockfile
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/code-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Code Tests

on:
pull_request:
branches: ['dev']
branches: ["dev"]
push:
branches: ['dev']
branches: ["dev"]

concurrency:
group: code-test-${{ github.event.pull_request.number || github.ref }}
Expand Down Expand Up @@ -34,15 +34,15 @@ jobs:
pkg-config

- name: Setup pnpm
uses: pnpm/action-setup@v4
uses: pnpm/action-setup@v5
with:
version: latest

- name: Setup Node.js
uses: actions/setup-node@v5
with:
node-version: lts/*
cache: 'pnpm'
cache: "pnpm"

Comment on lines 41 to 46
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new scripts/portable.test.mjs coverage for runPortableCli does not appear to run anywhere in CI (no workflow or package script invokes node --test). Consider adding a step in this workflow (after pnpm install) to execute the Node test suite so regressions in the portable CLI wrapper are caught automatically.

Copilot uses AI. Check for mistakes.
- name: Install frontend dependencies
run: pnpm install --frozen-lockfile
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/copilot-setup-steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: 'Copilot Setup Steps'
name: "Copilot Setup Steps"

on:
workflow_dispatch:
Expand Down Expand Up @@ -28,7 +28,7 @@ jobs:
node-version: lts/*

- name: Setup pnpm
uses: pnpm/action-setup@v4
uses: pnpm/action-setup@v5
with:
version: latest

Expand Down
Loading