Fix gazebo_ros:plugin_path in package.xml #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `${prefix}/lib` is wrong.
According to the [rospack implementation](https://github.com/ros/rospack/blob/8c5a699461f32f620204ccfaf93c5e5181f20f14/src/rospack.cpp#L2182), `${prefix}` is not context-dependent and get always expanded to the package path. If you're using devel space, this results in path to the package's source, not to the devel directory.
And really, this is from a DEBUG log of gazebo_ros.paths_plugin:
[DEBUG] [1575894134.676531222]: plugin path /opt/ros/cras_subt/src/realsense_gazebo_plugin/lib
The subexpression used in the PR works so that it asks catkin for the absolute path to the built library and takes the directory it resides in. This expression is evaluated at launch time, so we can be sure the library is already built at that time.
v-lopez
force-pushed
the
melodic-devel
branch
from
7482e02 to
b6df286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
${prefix}/libis wrong.According to the rospack implementation,
${prefix}is not context-dependent and get always expanded to the package path. If you're using devel space, this results in path to the package's source, not to the devel directory.And really, this is from a DEBUG log of gazebo_ros.paths_plugin:
The subexpression used in the PR works so that it asks catkin for the absolute path to the built library and takes the directory it resides in. This expression is evaluated at launch time, so we can be sure the library is already built at that time.