Add GoOffsetLocator that fulfills DwarfReader API. Use as shim for Go Uprobes #2207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
force-pushed
the
ddelnano/add-go-offset-locator
branch
from
cdf06a5 to
eed8c8d
Compare
This was referenced Jun 9, 2025
oazizi000
approved these changes
Jul 2, 2025
oazizi000
approved these changes
Jul 8, 2025
ddelnano
force-pushed
the
ddelnano/add-go-offset-locator
branch
from
f68e5f1 to
933c1e6
Compare
Signed-off-by: Dom Del Nano <[email protected]>
…overhead (memory) Go uprobes Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
…filing Signed-off-by: Dom Del Nano <[email protected]>
… multiple times Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]> (cherry picked from commit 7ce56b9)
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
force-pushed
the
ddelnano/add-go-offset-locator
branch
from
933c1e6 to
5093e7d
Compare
Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
force-pushed
the
ddelnano/add-go-offset-locator
branch
from
5093e7d to
b67f84c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add
GoOffsetLocatorthat fulfills DwarfReader APIs. Use as shim for Go UprobesOur current Go uprobe implementation relies on parsing DWARF information. This is memory intensive and is not ideal if end users want to keep the PEM's memory usage low (results in 100-150MB memory spikes).
In order to support lower memory uprobes and to support Go binaries without DWARF, we can introduce a shim for the existing DwarfReader API that can read the offsets from a file (via openteletrmy-go-instrumentation generated offsets) or from the existing DWARF information.
This PR introduces the
GoOffsetLocatorand tests that it functions properly while leaving the DWARF based tracing in place. The next set of changes will populate the offsets from pixie-io/opentelemetry-go-instrumentation#1 and provide configuration to choose the desired implementation: solely DWARF, solely static offsets or to use them in tandem.Relevant Issues: N/A
Type of change: /kind feature
Test Plan: Existing Go bpf trace tests should pass