Skip to content

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Sep 30, 2025

@dorimedini-starkware dorimedini-starkware self-assigned this Sep 30, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review September 30, 2025 10:42
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amosStarkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_os_flow_tests/src/test_manager.rs line 119 at r1 (raw file):

    pub(crate) fn perform_default_validations(&self) {
        self.perform_validations(true, None);
    }

It would be nice to have named variables for the parameters. non blocking

Code quote:

    pub(crate) fn perform_default_validations(&self) {
        self.perform_validations(true, None);
    }

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Oct 5, 2025
Merged via the queue into main with commit 536fb41 Oct 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants