Skip to content

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Oct 5, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Oct 5, 2025

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)


crates/starknet_api/src/state.rs line 324 at r1 (raw file):

                        .format_to_string(&abi)
                        .unwrap()
                })

without this change, the next PR fails the sanity check in test_v1_bound_accounts_cairo1.
@Yoni-Starkware FYI

Code quote:

            abi: cairo_lang_contract_class
                .abi
                .map(|abi| {
                    serde_json_fmt::JsonFormat::new()
                        .comma(", ")
                        .unwrap()
                        .colon(": ")
                        .unwrap()
                        .format_to_string(&abi)
                        .unwrap()
                })

Copy link

github-actions bot commented Oct 5, 2025

Benchmark movements: No major performance changes detected.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-02-starknet_os_flow_tests_migrate_test_v1_bound_accounts_cairo0 branch from e7199e0 to e875064 Compare October 5, 2025 07:52
@dorimedini-starkware dorimedini-starkware force-pushed the 10-03-starknet_api_fix_compiler-_snapi_contract_class_abi_string_conversion_for_tests branch from 2c6c6b1 to 2d5444b Compare October 5, 2025 07:52
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)


crates/starknet_api/src/state.rs line 317 at r1 (raw file):

                .abi
                .map(|abi| {
                    serde_json_fmt::JsonFormat::new()

apparently, this crate adds smart-string which changes String under the hood... so I'll need to implement this formatter manually

Code quote:

serde_json_fmt::JsonFormat

@dorimedini-starkware dorimedini-starkware force-pushed the 10-03-starknet_api_fix_compiler-_snapi_contract_class_abi_string_conversion_for_tests branch 2 times, most recently from 84efe89 to 266fcb1 Compare October 5, 2025 09:16
@dorimedini-starkware dorimedini-starkware force-pushed the 10-02-starknet_os_flow_tests_migrate_test_v1_bound_accounts_cairo0 branch from e875064 to 896b42a Compare October 5, 2025 09:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-03-starknet_api_fix_compiler-_snapi_contract_class_abi_string_conversion_for_tests branch from 266fcb1 to 33811c4 Compare October 5, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants