-
Notifications
You must be signed in to change notification settings - Fork 66
starknet_api: fix compiler->SNAPI contract class ABI string conversion for tests #9494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 10-02-starknet_os_flow_tests_migrate_test_v1_bound_accounts_cairo0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
crates/starknet_api/src/state.rs
line 324 at r1 (raw file):
.format_to_string(&abi) .unwrap() })
without this change, the next PR fails the sanity check in test_v1_bound_accounts_cairo1
.
@Yoni-Starkware FYI
Code quote:
abi: cairo_lang_contract_class
.abi
.map(|abi| {
serde_json_fmt::JsonFormat::new()
.comma(", ")
.unwrap()
.colon(": ")
.unwrap()
.format_to_string(&abi)
.unwrap()
})
Benchmark movements: No major performance changes detected. |
e7199e0
to
e875064
Compare
2c6c6b1
to
2d5444b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
crates/starknet_api/src/state.rs
line 317 at r1 (raw file):
.abi .map(|abi| { serde_json_fmt::JsonFormat::new()
apparently, this crate adds smart-string
which changes String
under the hood... so I'll need to implement this formatter manually
Code quote:
serde_json_fmt::JsonFormat
84efe89
to
266fcb1
Compare
e875064
to
896b42a
Compare
266fcb1
to
33811c4
Compare
No description provided.