starknet_os_flow_tests: migrate test_reverted_invoke_tx

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• starknet_os_flow_tests: change FlowTestTx to enum #9501
• starknet_os_flow_tests: migrate test_v1_bound_accounts_cairo1 #9496
• starknet_os_flow_tests: add V1-bound cairo1 account for flow tests #9495
• starknet_api: fix compiler->SNAPI contract class ABI string conversion for tests #9494
• starknet_os_flow_tests: migrate test_v1_bound_accounts_cairo0 #9493
• starknet_os_flow_tests: split get_class_info_of_cairo0_contract into function #9492
• starknet_os_flow_tests: more informative execution failure #9491
• starknet_os_flow_tests: add V1-bound cairo0 account for flow tests #9490
• starknet_os_flow_tests: localize expected storage updates in test_os_logic #9485
• starknet_os_flow_tests: migrate test_os_logic and some small refactors #9484
• blockifier_test_utils: add functionality to test contract for test_os_logic #9483
• blockifier_test_utils: add test_contract2 cairo0 contract #9482
• blockifier_test_utils: add delegate_proxy cairo0 contract #9481
• starknet_os_flow_tests: add control for expected reverting txs #9480
• starknet_os_flow_tests: migrate test_reverted_l1_handler_tx #9474
• starknet_os_flow_tests: migrate test_reverted_invoke_tx #9473 👈 (View in Graphite)
• starknet_os_flow_tests: reduce boilerplate with perform_default_validations #9472
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[AvivYossef-starkware]

Do you have access to the reason for reverting?
If so,, can you verify that the revert reason is as expected?

@AvivYossef-starkware reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @meship-starkware and @Yoni-Starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 263 at r1 (raw file):

        sender_address: *FUNDED_ACCOUNT_ADDRESS,
        nonce: nonce_manager.next(*FUNDED_ACCOUNT_ADDRESS),
        calldata: create_calldata(test_contract_address, "write_and_revert", &[]),

The entry point needs to receive a value (storage write).

Code quote:

calldata: create_calldata(test_contract_address, "write_and_revert", &[])

---

crates/starknet_os_flow_tests/src/tests.rs line 284 at r1 (raw file):

    assert!(
        test_output.decompressed_state_diff.storage_updates.contains_key(&STRK_FEE_TOKEN_ADDRESS)
    );

Can you check that srorage key[FUNDED_ACCOUNT_ADDRESS] has changed? ( for the STRK_FEE_TOKEN_ADDRESS )

Code quote:

    assert!(
        test_output.decompressed_state_diff.storage_updates.contains_key(&STRK_FEE_TOKEN_ADDRESS)
    );

---

crates/blockifier_test_utils/resources/feature_contracts/cairo1/test_contract.cairo line 63 at r1 (raw file):

    }

    #[external(v0)]

Can you use test_revert_helper ?
( or do you want to be more specific )

Code quote:

    fn write_and_revert(self: @ContractState, address: StorageAddress, value: felt252) {
        let address_domain = 0;
        syscalls::storage_write_syscall(address_domain, address, value).unwrap_syscall();
        assert(1 == 0, 'Panic for revert');
    }

    #[external(v0)]

[dorimedini-starkware]

already done :) (2 PRs ahead of this one)

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 263 at r1 (raw file):

Previously, AvivYossef-starkware wrote…

The entry point needs to receive a value (storage write).

you are correct, this is caught and fixed here, where I add control over revert reasons

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/blockifier_test_utils/resources/feature_contracts/cairo1/test_contract.cairo line 63 at r1 (raw file):

Previously, AvivYossef-starkware wrote…

Can you use test_revert_helper ?
( or do you want to be more specific )

1. I want to be more specific
2. I want to use the same call and calldata for both cairo0 and cairo1 contracts - test_revert_helper is not on the cairo0 contract

[AvivYossef-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 263 at r1 (raw file):

Previously, dorimedini-starkware wrote…

you are correct, this is caught and fixed here, where I add control over revert reasons

sababa

---

crates/starknet_os_flow_tests/src/tests.rs line 243 at r1 (raw file):

#[rstest]
#[tokio::test]
async fn test_reverted_invoke_tx(

Suggestion:

/// This test verifies that when an entry point modifies storage and then reverts (panics):
/// 1. All storage changes made before the revert are properly rolled back.
/// 2. The transaction fee is still deducted from the caller's account.
async fn test_reverted_invoke_tx(

---

crates/starknet_os_flow_tests/src/tests.rs line 284 at r1 (raw file):

    assert!(
        test_output.decompressed_state_diff.storage_updates.contains_key(&STRK_FEE_TOKEN_ADDRESS)
    );

Can we verify specifically that the sender's balance changes?

Code quote:

    assert!(
        test_output.decompressed_state_diff.storage_updates.contains_key(&STRK_FEE_TOKEN_ADDRESS)
    );

[dorimedini-starkware]

Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 263 at r1 (raw file):

Previously, AvivYossef-starkware wrote…

sababa

Done.

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware and @Yoni-Starkware)

[graphite-app]

Merge activity

• Oct 5, 10:26 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.